1381716 - The Onboarding tour should also detect the url of the activity-stream page for display

Status: RESOLVED WORKSFORME

(Firefox :: General, enhancement, P2)

Description

[Fischer [:Fischer]]

We should also detect if the url of the activity-stream page is present then display the onboarding tour. Currently only detect about:home and about:newtab.

Comment 1

[[e-mail]]

mardak, I guess activity-stream will still use `about:home` URL once AS replaced current about:home page, is it right?

If so we don't need to handle this issue.

Comment 2

[Ed Lee :Mardak]

Yeah it should just work when activity stream replaces about:home. Just like how onboarding already works on the about:newtab page (for both activity stream and tiles).

Comment 3

[Francis Lee [:frlee]]

remove whiteboard tag due to its WROKSFORME

Comment 4

[Fischer [:Fischer]]

Hi Kate,
Just to check with you about the schedule that put the AS page in about:home. We haven't seen that happened until now. Dose the AS team still plan to do that in FF57?
Because we are seeing some discussion about the onboarding tour on the old about:home, if the AS page will be about:home, then everything is fine. If not, the onboarding probably needs some discussion about that, thank you.

p.s Ed is PTO so ni? you.

Comment 5

[Ed Lee :Mardak]

Yes the plan is to have `about:home` uri load activity stream https://github.com/mozilla/activity-stream/issues/2598

So if the current onboarding code is detecting "about:home" then it should just work.