1381717 - [Fennec][HLS] Fix code defects found by Coverity in GeckoHlsPlayer.java

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Audio/Video, defect, P3)

Description

[James Cheng[:JamesCheng]]

https://scan4.coverity.com/reports.htm#v27811/p11134/fileInstanceId=22435006&defectInstanceId=4484549&mergedDefectId=147801

Lots of "GUARDED_BY_VIOLATION" issues reported.

Need to handle it at once.

Comment 1

[James Cheng[:JamesCheng]]

Attachment: Bug 1381717 - [Fennec][HLS] Fix code defects found by Coverity in GeckoHlsPlayer.java. krr.

Review commit: https://reviewboard.mozilla.org/r/158122/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/158122/

Comment 2

[Kilik Kuo [:kikuo] (inactive)]

Comment on attachment 8887309 [details]
Bug 1381717 - [Fennec][HLS] Fix code defects found by Coverity in GeckoHlsPlayer.java. krr.

https://reviewboard.mozilla.org/r/158122/#review163902

::: mobile/android/geckoview/src/main/java/org/mozilla/gecko/media/GeckoHlsPlayer.java:597
(Diff revision 1)
>      // =======================================================================
>      // API for GeckoHLSDemuxerWrapper
>      // =======================================================================
>      // Called on HLSDemuxer's TaskQueue
>      @Override
> -    public ConcurrentLinkedQueue<GeckoHLSSample> getSamples(TrackType trackType,
> +    public synchronized ConcurrentLinkedQueue<GeckoHLSSample> getSamples(TrackType trackType,

Though this is not what I expect...we're losing the concurrency here because we should be able to make the sample retrieval in parallel.

Besides, we're getting sample by calling HLSTrackDemuxer::GetSample on HLSDemuxer taskqueue sequeuncialy. So, we limited the capability already ... :(

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a3de4e17cfd3
[Fennec][HLS] Fix code defects found by Coverity in GeckoHlsPlayer.java. krr. r=kikuo

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a3de4e17cfd3