Closed Bug 1381717 Opened 3 years ago Closed 3 years ago

[Fennec][HLS] Fix code defects found by Coverity in GeckoHlsPlayer.java

Categories

(Firefox for Android :: Audio/Video, defect, P3)

defect

Tracking

()

RESOLVED FIXED
Firefox 56
Tracking Status
firefox56 --- fixed

People

(Reporter: JamesCheng, Assigned: JamesCheng)

References

Details

Attachments

(1 file)

Priority: -- → P3
Comment on attachment 8887309 [details]
Bug 1381717 - [Fennec][HLS] Fix code defects found by Coverity in GeckoHlsPlayer.java. krr.

https://reviewboard.mozilla.org/r/158122/#review163902

::: mobile/android/geckoview/src/main/java/org/mozilla/gecko/media/GeckoHlsPlayer.java:597
(Diff revision 1)
>      // =======================================================================
>      // API for GeckoHLSDemuxerWrapper
>      // =======================================================================
>      // Called on HLSDemuxer's TaskQueue
>      @Override
> -    public ConcurrentLinkedQueue<GeckoHLSSample> getSamples(TrackType trackType,
> +    public synchronized ConcurrentLinkedQueue<GeckoHLSSample> getSamples(TrackType trackType,

Though this is not what I expect...we're losing the concurrency here because we should be able to make the sample retrieval in parallel.

Besides, we're getting sample by calling HLSTrackDemuxer::GetSample on HLSDemuxer taskqueue sequeuncialy. So, we limited the capability already ... :(
Attachment #8887309 - Flags: review?(kikuo) → review+
Pushed by jacheng@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a3de4e17cfd3
[Fennec][HLS] Fix code defects found by Coverity in GeckoHlsPlayer.java. krr. r=kikuo
https://hg.mozilla.org/mozilla-central/rev/a3de4e17cfd3
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
You need to log in before you can comment on or make changes to this bug.