1381963 - Firefox Screenshots icon briefly shows then disappears

Status: RESOLVED FIXED

(Firefox :: Screenshots, defect)

Description

[Asa Dotzler [:asa]]

On a new profile with latest nightly on launch I see the Firefox Screenshots icon appear and then disappear from the far right of the main toolbar. 

Tested with 7/18 build 

This icon should never show if it's not supposed to or it should stay put if it's supposed to.

Comment 1

[:Gijs (he/him)]

Can you provide a screenshot of what you're seeing?

Comment 2

[:Gijs (he/him)]

(In reply to :Gijs from comment #1)
> Can you provide a screenshot of what you're seeing?

err, I meant screencast. :-)

Comment 3

[Asa Dotzler [:asa]]

https://youtu.be/2hLEL0NNdco

Comment 4

[Asa Dotzler [:asa]]

(In reply to Asa Dotzler [:asa] from comment #3)
> https://youtu.be/2hLEL0NNdco

You'll want to skip the first 40 seconds or so (that's normal startup time on this machine.)

Comment 5

[:Gijs (he/him)]

(In reply to Asa Dotzler [:asa] from comment #4)
> (In reply to Asa Dotzler [:asa] from comment #3)
> > https://youtu.be/2hLEL0NNdco
> 
> You'll want to skip the first 40 seconds or so (that's normal startup time
> on this machine.)

Thanks! Yeah, this looks like a screenshots issue to me, it's not being removed entirely (there's too much space left at the end - can you still hover over it if you aim for the middle of the toolbar, getting a bizarrely small little square for a hover state with no icon in it?) and not being put in the overflow menu or something, so I think the add-on must be doing something to remove the icon, or try to use an icon that's not being packaged or something. Hopefully :ian or :jgruen know more.


Also, bizarrely, I just noticed I'm seeing this myself on 55 beta. On my main profile on my mbp. I'll see if I can find something out...

Comment 6

[Asa Dotzler [:asa]]

(In reply to :Gijs from comment #5)

> removed entirely (there's too much space left at the end - can you still
> hover over it if you aim for the middle of the toolbar, getting a bizarrely
> small little square for a hover state with no icon in it?) 

Yes. There is a little gray square on mouseover where the screenshots icon used to be. If I click it the icon returns and screenshot functionality starts up.

Comment 7

[John Gruen [:jgruen]]

:asa :gijs

This is a known issue and should be resolved by https://bugzilla.mozilla.org/show_bug.cgi?id=1381132

Comment 8

[Asa Dotzler [:asa]]

Great! Sorry for the duplicate :)

Comment 9

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

One issue we've seen in Screenshots is the icon going missing, because the path to the icon was incorrect. That is the bug fix contained in bug 1381132.

I think this is likely a dupe, but some discussion in the teamaddons channel suggests that we may not be shutting down correctly as part of the update process.

Gijs, did you see anything to suggest this was a bigger issue than a missing icon?

Hopefully, by the time you read this, the patch in bug 1381132 will have landed, and we'll be able to determine if this bug is a dupe or not.

Comment 10

[:Gijs (he/him)]

(In reply to Jared Hirsch [:_6a68] [:jhirsch] from comment #9)
> One issue we've seen in Screenshots is the icon going missing, because the
> path to the icon was incorrect. That is the bug fix contained in bug 1381132.
> 
> I think this is likely a dupe, but some discussion in the teamaddons channel
> suggests that we may not be shutting down correctly as part of the update
> process.
> 
> Gijs, did you see anything to suggest this was a bigger issue than a missing
> icon?

Well, none of the URLs (including parent directories etc.) seem to work in the URL bar on beta. I don't know if that is just a bug in our moz-extension handling. I also saw that the startup promise was pending when requesting the webextension object from legacyextensionsutils - which, again, could be a webextensions bug? Not sure.

Comment 13

[Wil Clouser [:clouserw]]

This is fixed in the latest versions.  Thanks!

Comment 14

[Md. Majedul islam]

I have reproduced this bug with Nightly 56.0a1 (2017-07-18) on Ubuntu 16.04, 64 bit!

The fix is now verified on Latest Nightly 56.0a1 .

Build ID 	20170727100240
User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:56.0) Gecko/20100101 Firefox/56.0

[bugday-20170726]