1381984 - Replace StringUtils.join with TextUtils.join

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, enhancement, P1)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

They're equivalent.

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Bug 1381984: Replace StringUtils.join with TextUtils.join.

I verified the behavior is the same by replacing StringUtils.join with
TextUtils.join in the StringUtils.join test (which passed) before deleting it
all.

Review commit: https://reviewboard.mozilla.org/r/158536/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/158536/

Comment 2

[Chenxia Liu [:liuche]]

Comment on attachment 8887649 [details]
Bug 1381984: Replace StringUtils.join with TextUtils.join.

https://reviewboard.mozilla.org/r/158536/#review164354

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d38c3ad6fe5b
Replace StringUtils.join with TextUtils.join. r=liuche

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Backed out for breaking the various Android linter/checkstyle/etc jobs.
https://hg.mozilla.org/integration/autoland/rev/02b3fd4876ff55b8e8a04e650ccd067bfcded748

https://treeherder.mozilla.org/logviewer.html#?job_id=115739685&repo=autoland

INFO -  /home/worker/workspace/build/src/mobile/android/geckoview/src/main/java/org/mozilla/gecko/util/publicsuffix/PublicSuffix.java:62: error: cannot find symbol
INFO -              String ancestorName = TextUtils.join(".", parts.subList(i, partsSize));
INFO -                                    ^
INFO -    symbol:   variable TextUtils
INFO -    location: class PublicSuffix

Comment 5

[Ryan VanderMeulen [:RyanVM]]

And Android x86 builds.
https://treeherder.mozilla.org/logviewer.html#?job_id=115740243&repo=autoland

Comment 6

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8887649 [details]
Bug 1381984: Replace StringUtils.join with TextUtils.join.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158536/diff/1-2/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9c7f4cb53632
Replace StringUtils.join with TextUtils.join. r=liuche

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9c7f4cb53632