1382016 - `autospider.sh nonunified` fails on Mac

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement)

Description

[Jason Orendorff [:jorendorff]]

It fails because Mac sed requires an argument after -i.

It can be empty: `sed -i '' s/blah/blah`

Comment 1

[Jason Orendorff [:jorendorff]]

Attachment: Fix autospider.sh nonunified on Mac

Comment 2

[Steve Fink [:sfink] [:s:]]

Comment on attachment 8887684 [details] [diff] [review]
Fix autospider.sh nonunified on Mac

Review of attachment 8887684 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/devtools/automation/autospider.py
@@ +145,5 @@
> +            in_place = ['-i']
> +            if platform.system() == 'Darwin':
> +                in_place.append('')
> +            subprocess.check_call(['sed'] + in_place + ['s/UNIFIED_SOURCES/SOURCES/',
> +                                                        os.path.join(dirpath, 'moz.build')])

Does this work on osx by any chance?

  sed --in-place= 's/blah/bah'

(I doubt it, but just checking.) Either way, r=me.

Comment 3

[Jason Orendorff [:jorendorff]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=98ba588143ae2c3ec9c4f85eb48e72f8fd728e3f

Comment 4

[Jason Orendorff [:jorendorff]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4be5c2ff3c1ea1d28469dc472b0189adeafe0014
Bug 1382016 - Fix autospider.sh nonunified on Mac. r=sfink

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4be5c2ff3c1e