Closed
Bug 1382016
Opened 7 years ago
Closed 7 years ago
`autospider.sh nonunified` fails on Mac
Categories
(Core :: JavaScript Engine, enhancement)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: jorendorff, Assigned: jorendorff)
Details
Attachments
(1 file)
1.67 KB,
patch
|
sfink
:
review+
|
Details | Diff | Splinter Review |
It fails because Mac sed requires an argument after -i. It can be empty: `sed -i '' s/blah/blah`
Assignee | ||
Comment 1•7 years ago
|
||
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → jorendorff
Status: NEW → ASSIGNED
Assignee | ||
Updated•7 years ago
|
Attachment #8887684 -
Flags: review?(sphink)
Comment 2•7 years ago
|
||
Comment on attachment 8887684 [details] [diff] [review] Fix autospider.sh nonunified on Mac Review of attachment 8887684 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/src/devtools/automation/autospider.py @@ +145,5 @@ > + in_place = ['-i'] > + if platform.system() == 'Darwin': > + in_place.append('') > + subprocess.check_call(['sed'] + in_place + ['s/UNIFIED_SOURCES/SOURCES/', > + os.path.join(dirpath, 'moz.build')]) Does this work on osx by any chance? sed --in-place= 's/blah/bah' (I doubt it, but just checking.) Either way, r=me.
Attachment #8887684 -
Flags: review?(sphink) → review+
Assignee | ||
Comment 3•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=98ba588143ae2c3ec9c4f85eb48e72f8fd728e3f
Assignee | ||
Comment 4•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/4be5c2ff3c1ea1d28469dc472b0189adeafe0014 Bug 1382016 - Fix autospider.sh nonunified on Mac. r=sfink
Comment 5•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/4be5c2ff3c1e
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•