Closed Bug 1382016 Opened 7 years ago Closed 7 years ago

`autospider.sh nonunified` fails on Mac

Categories

(Core :: JavaScript Engine, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: jorendorff, Assigned: jorendorff)

Details

Attachments

(1 file)

It fails because Mac sed requires an argument after -i.

It can be empty: `sed -i '' s/blah/blah`
Assignee: nobody → jorendorff
Status: NEW → ASSIGNED
Attachment #8887684 - Flags: review?(sphink)
Comment on attachment 8887684 [details] [diff] [review]
Fix autospider.sh nonunified on Mac

Review of attachment 8887684 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/devtools/automation/autospider.py
@@ +145,5 @@
> +            in_place = ['-i']
> +            if platform.system() == 'Darwin':
> +                in_place.append('')
> +            subprocess.check_call(['sed'] + in_place + ['s/UNIFIED_SOURCES/SOURCES/',
> +                                                        os.path.join(dirpath, 'moz.build')])

Does this work on osx by any chance?

  sed --in-place= 's/blah/bah'

(I doubt it, but just checking.) Either way, r=me.
Attachment #8887684 - Flags: review?(sphink) → review+
https://hg.mozilla.org/mozilla-central/rev/4be5c2ff3c1e
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.