Closed
Bug 1382027
Opened 7 years ago
Closed 7 years ago
Allow using an SVG <image> (SVGImageElement) as a CanvasImageSource
Categories
(Core :: DOM: Core & HTML, enhancement, P1)
Tracking
()
RESOLVED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: bzbarsky, Assigned: bzbarsky)
Details
(Keywords: dev-doc-complete)
Attachments
(1 file)
11.36 KB,
patch
|
nika
:
review+
|
Details | Diff | Splinter Review |
Looks like the spec got changed to allow this at some point.
Assignee | ||
Comment 1•7 years ago
|
||
Attachment #8887777 -
Flags: review?(michael)
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Updated•7 years ago
|
Priority: -- → P1
Updated•7 years ago
|
Attachment #8887777 -
Flags: review?(michael) → review+
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c99d20ba408a
Allow using an SVGImageElement as a CanvasImageSource. r=mystor
Comment 3•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Updated•7 years ago
|
Keywords: dev-doc-needed
Comment 4•7 years ago
|
||
Hi Boris, is manual testing needed for this feature? If it's a yes, could you please file a request with the details to pi-request@mozilla.com?
Flags: qe-verify?
Flags: needinfo?(bzbarsky)
Assignee | ||
Comment 5•7 years ago
|
||
I don't think manual testing is needed here; the patch includes automated tests.
Flags: needinfo?(bzbarsky)
Comment 6•7 years ago
|
||
I've documented this by making sure it is mentioned appropriately in
https://developer.mozilla.org/en-US/docs/Web/API/CanvasRenderingContext2D/drawImage
https://developer.mozilla.org/en-US/docs/Web/API/Canvas_API/Tutorial/Using_images
https://developer.mozilla.org/en-US/docs/Web/API/CanvasImageSource
and adding a note to the Fx56 rel notes:
https://developer.mozilla.org/en-US/Firefox/Releases/56#Canvas_and_WebGL
Let me know if you notice anything untoward. Thanks!
Keywords: dev-doc-needed → dev-doc-complete
Updated•6 years ago
|
Flags: qe-verify? → qe-verify-
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•