1382041 - screenshots needs a unit test to ensure that auto-upgrade works

Status: RESOLVED INVALID

(Firefox :: Screenshots, enhancement)

Description

[Robert Helmer [:rhelmer]]

As with other add-on updates, system add-ons can be updated restartlessly at any time.

Screenshots should have a unit test to help ensure that the built-in version is shut down correctly and the updated version is installed.

There is a working example in http://searchfox.org/mozilla-central/source/toolkit/mozapps/extensions/test/xpcshell/test_system_update.js but the gist is:

1) register a "XREAppDist" (built-in) and "XREAppFeat" (updates) dir with the directory service provider
2) modify the `extensions.systemAddon.update.url` pref to point to a URL (can be a file://) with an XML file specifying your update
3) trigger a background update check (http://searchfox.org/mozilla-central/rev/a83a4b68974aecaaacdf25145420e0fe97b7aa22/toolkit/mozapps/extensions/test/xpcshell/head_addons.js#1333)

https://gecko.readthedocs.io/en/latest/toolkit/mozapps/extensions/addon-manager/SystemAddons.html has some high-level info on the update process.

We can also refactor the test methods in the add-ons manager code above into stuff that can live in `AddonTestUtils.jsm` and be shared more easily across the tree too.

Comment 1

[Emma Malysz]

Since this component is now maintained in tree, I'm going to close this out

For future tests, we should file them as blocking Bug 1692626