Crash in mozilla::dom::TabChild::InternalSetDocShellIsActive

RESOLVED FIXED in Firefox 56

Status

()

Core
DOM: Content Processes
--
critical
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: ting, Assigned: Nika)

Tracking

({crash})

Trunk
mozilla56
Unspecified
Windows 7
crash
Points:
---

Firefox Tracking Flags

(firefox-esr52 unaffected, firefox54 unaffected, firefox55 unaffected, firefox56 fixed)

Details

(crash signature)

Attachments

(1 attachment)

(Reporter)

Description

a year ago
This bug was filed from the Socorro interface and is 
report bp-56e8dae9-89f0-4b3e-b99e-c55240170718.
=============================================================
Top #24 of Nightly 20170716030208 on Windows, 9 reports from 7 installations. The first observation was from build 20170714030205, bug 1378281 seems the culprit.
(Reporter)

Updated

a year ago
Flags: needinfo?(michael)
(Assignee)

Comment 1

a year ago
Created attachment 8887965 [details] [diff] [review]
Null check docShell in InternalSetDocShellIsActive

It looks like the line which we were crashing on was dereferencing a non-null-checked docShell variable. This should avoid that situation.

MozReview-Commit-ID: JHtmTSomFlb
Attachment #8887965 - Flags: review?(bugs)
(Assignee)

Updated

a year ago
Assignee: nobody → michael
Flags: needinfo?(michael)
Attachment #8887965 - Flags: review?(bugs) → review+

Comment 2

a year ago
Pushed by michael@thelayzells.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/508e4725fa73
Null check docShell in InternalSetDocShellIsActive, r=smaug

Comment 3

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/508e4725fa73
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
status-firefox54: --- → unaffected
status-firefox55: --- → unaffected
status-firefox-esr52: --- → unaffected
You need to log in before you can comment on or make changes to this bug.