Closed Bug 1382120 Opened 4 years ago Closed 4 years ago

Fix remaining failed allowpaymentrequest web platform tests

Categories

(Core :: DOM: Web Payments, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: ben.tian, Assigned: alchen)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 2 obsolete files)

Fix remaining failed allowpaymentrequest web platform tests after bug 1318988 lands:
- removing-allowpaymentrequest.https.sub.html
- setting-allowpaymentrequest-timing.https.sub.html
- setting-allowpaymentrequest.https.sub.html
We can pass the tests if we change the way to set/remove the attribute.


From  iframe.allowPaymentRequest = true;
To    iframe.setAttribute('allowpaymentrequest', '');


From  iframe.allowPaymentRequest = false;
To    iframe.removeAttribute('allowpaymentrequest');
Need to add 'allowpaymentrequest' attribute into HTMLIFrameElement.webidl. With the patch, we can pass some wpt tests in reflection-embedded.html and interfaces.html.
Attachment #8887871 - Flags: review?(amarchesini)
Comment on attachment 8887871 [details] [diff] [review]
Add 'allowPaymentRequest' into HTMLIFrameElement interface

Review of attachment 8887871 [details] [diff] [review]:
-----------------------------------------------------------------

Where is the implementation of this attribute?
Attachment #8887871 - Flags: review?(amarchesini)
Comment on attachment 8887871 [details] [diff] [review]
Add 'allowPaymentRequest' into HTMLIFrameElement interface

> Where is the implementation of this attribute?

The implementation is in the attachment 8887310 [details] [diff] [review] of bug 1318988.
I didn't add the attribute into webidl at that time.
Attachment #8887871 - Flags: review?(amarchesini)
Comment on attachment 8887871 [details] [diff] [review]
Add 'allowPaymentRequest' into HTMLIFrameElement interface

Review of attachment 8887871 [details] [diff] [review]:
-----------------------------------------------------------------

Ok! Now it makes sense. Thanks!
Attachment #8887871 - Flags: review?(amarchesini) → review+
Status: NEW → ASSIGNED
Keywords: checkin-needed
Attachment #8887815 - Attachment is obsolete: true
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/93aa802eeb9d
Add 'allowPaymentRequest' into HTMLIFrameElement interface. r=baku
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/93aa802eeb9d
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.