Fix remaining failed allowpaymentrequest web platform tests

RESOLVED FIXED in Firefox 56

Status

()

Core
DOM: Web Payments
RESOLVED FIXED
3 months ago
3 months ago

People

(Reporter: btian, Assigned: alchen)

Tracking

(Blocks: 1 bug)

unspecified
mozilla56
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox56 fixed)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

3 months ago
Fix remaining failed allowpaymentrequest web platform tests after bug 1318988 lands:
- removing-allowpaymentrequest.https.sub.html
- setting-allowpaymentrequest-timing.https.sub.html
- setting-allowpaymentrequest.https.sub.html
(Assignee)

Comment 1

3 months ago
Created attachment 8887815 [details] [diff] [review]
change the way to set/remove the 'allowpaymentrequest' attribute

We can pass the tests if we change the way to set/remove the attribute.


From  iframe.allowPaymentRequest = true;
To    iframe.setAttribute('allowpaymentrequest', '');


From  iframe.allowPaymentRequest = false;
To    iframe.removeAttribute('allowpaymentrequest');
(Assignee)

Comment 2

3 months ago
Created attachment 8887871 [details] [diff] [review]
Add 'allowPaymentRequest' into HTMLIFrameElement interface

Need to add 'allowpaymentrequest' attribute into HTMLIFrameElement.webidl. With the patch, we can pass some wpt tests in reflection-embedded.html and interfaces.html.
Attachment #8887871 - Flags: review?(amarchesini)
Comment on attachment 8887871 [details] [diff] [review]
Add 'allowPaymentRequest' into HTMLIFrameElement interface

Review of attachment 8887871 [details] [diff] [review]:
-----------------------------------------------------------------

Where is the implementation of this attribute?
Attachment #8887871 - Flags: review?(amarchesini)
(Assignee)

Comment 4

3 months ago
Comment on attachment 8887871 [details] [diff] [review]
Add 'allowPaymentRequest' into HTMLIFrameElement interface

> Where is the implementation of this attribute?

The implementation is in the attachment 8887310 [details] [diff] [review] of bug 1318988.
I didn't add the attribute into webidl at that time.
Attachment #8887871 - Flags: review?(amarchesini)
Comment on attachment 8887871 [details] [diff] [review]
Add 'allowPaymentRequest' into HTMLIFrameElement interface

Review of attachment 8887871 [details] [diff] [review]:
-----------------------------------------------------------------

Ok! Now it makes sense. Thanks!
Attachment #8887871 - Flags: review?(amarchesini) → review+
(Assignee)

Comment 6

3 months ago
Created attachment 8889257 [details] [diff] [review]
Add 'allowPaymentRequest' into HTMLIFrameElement interface. r=baku

Try server:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=853327798391b0f8b29d1e0ab52684fae3dfd6a3
Attachment #8887871 - Attachment is obsolete: true
Attachment #8889257 - Flags: review+
(Assignee)

Updated

3 months ago
Status: NEW → ASSIGNED
Keywords: checkin-needed
Attachment #8887815 - Attachment is obsolete: true

Comment 7

3 months ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/93aa802eeb9d
Add 'allowPaymentRequest' into HTMLIFrameElement interface. r=baku
Keywords: checkin-needed

Comment 8

3 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/93aa802eeb9d
Status: ASSIGNED → RESOLVED
Last Resolved: 3 months ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.