1382120 - Fix remaining failed allowpaymentrequest web platform tests

Status: RESOLVED FIXED

(Core :: DOM: Web Payments, enhancement)

Description

[Ben Tian (inactive)]

Fix remaining failed allowpaymentrequest web platform tests after bug 1318988 lands:
- removing-allowpaymentrequest.https.sub.html
- setting-allowpaymentrequest-timing.https.sub.html
- setting-allowpaymentrequest.https.sub.html

Comment 1

[Alphan Chen [:alchen]]

Attachment: change the way to set/remove the 'allowpaymentrequest' attribute

We can pass the tests if we change the way to set/remove the attribute.


From  iframe.allowPaymentRequest = true;
To    iframe.setAttribute('allowpaymentrequest', '');


From  iframe.allowPaymentRequest = false;
To    iframe.removeAttribute('allowpaymentrequest');

Comment 2

[Alphan Chen [:alchen]]

Attachment: Add 'allowPaymentRequest' into HTMLIFrameElement interface

Need to add 'allowpaymentrequest' attribute into HTMLIFrameElement.webidl. With the patch, we can pass some wpt tests in reflection-embedded.html and interfaces.html.

Comment 3

[Andrea Marchesini [:baku]]

Comment on attachment 8887871 [details] [diff] [review]
Add 'allowPaymentRequest' into HTMLIFrameElement interface

Review of attachment 8887871 [details] [diff] [review]:
-----------------------------------------------------------------

Where is the implementation of this attribute?

Comment 4

[Alphan Chen [:alchen]]

Comment on attachment 8887871 [details] [diff] [review]
Add 'allowPaymentRequest' into HTMLIFrameElement interface

> Where is the implementation of this attribute?

The implementation is in the attachment 8887310 [details] [diff] [review] of bug 1318988.
I didn't add the attribute into webidl at that time.

Comment 5

[Andrea Marchesini [:baku]]

Comment on attachment 8887871 [details] [diff] [review]
Add 'allowPaymentRequest' into HTMLIFrameElement interface

Review of attachment 8887871 [details] [diff] [review]:
-----------------------------------------------------------------

Ok! Now it makes sense. Thanks!

Comment 6

[Alphan Chen [:alchen]]

Attachment: Add 'allowPaymentRequest' into HTMLIFrameElement interface. r=baku

Try server:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=853327798391b0f8b29d1e0ab52684fae3dfd6a3

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/93aa802eeb9d
Add 'allowPaymentRequest' into HTMLIFrameElement interface. r=baku

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/93aa802eeb9d