1382125 - [Tablet] Closed tab remains visible in tab bar

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: Theme and Visual Design, defect, P5)

Description

[knipesteven]

Attachment: Screenshot_20170718-232531.png

User Agent: Mozilla/5.0 (Android 7.0; Tablet; rv:55.0) Gecko/55.0 Firefox/55.0
Build ID: 20170710193228

Steps to reproduce:

Closed a tab (inconsistent but it's happened twice now)


Actual results:

The tab closed but the tab graphic remained


Expected results:

Tab should visually disappear from the bar

Comment 1

[knipesteven]

Attachment: Screenshot_20170716-234940.png

Comment 2

[knipesteven]

Forgot to mention: I am using Firefox Beta 55.0b8 on Android 7.0, shield tablet k1.

Comment 3

[knipesteven]

Update: I have figured out a way to reliably trigger the bug.

1) open at least two tabs
2) press and hold the x button on a non-active tab for ~1 second
3) release

This button only appears on the tablet interface. On the phone interface only the active tab has an x button.

Comment 4

[tossj]

I am also getting this error. I am running Firefox 55.0.2 20170815231002 on Android 4.2.2. I can reproduce the issue by following ssk97's instructions above.

Comment 5

[Sorina Florean [:sflorean]]

Thanks for report!
Tried to reproduce the issue with Samsung Galaxy Tab S3 (Android 7.0) and Huawei MediaPad M2 (Android 5.1.1)  but the closed tab was not displayed following the steps from comment 3. Is this still reproducing? Could you please install the latest Nightly (from here - http://archive.mozilla.org/pub/mobile/nightly/2018/02/ and try again? Thanks

Comment 6

[knipesteven]

I just tried it on 60.0a1 (2018-02-19) and it still happens despite the different looking UI. It also seems to work on the active tab. Note that this is done on the main browser screen, the tablet interface has the tabs on the top of that screen.

If another tab goes on top of the previous one then the closed tab can be hidden behind that tab. I have not done testing to determine how the ordering of the tabs is determined. Interestingly the closed tab will change shade while pressed (like a normal tab), but it does nothing else (can't be dragged around or switched to)

On a side note I have no idea what I was saying about the phone interface on that previous comment, the phone interface doesn't have the tabs at all.

Comment 7

[Oana Horvath [:ohorvath]]

I was able to reproduce it finally, with the STR described, on a Huawei MediaPad M2 (Android 5.1.1). Can't 100% reproduce it though, so I'm unable to find a regression window.
Build: Nightly 60.0a1 (2018-02-26).

Comment 8

[knipesteven]

I just tried using mozregression (first time using it) and managed to get it down to here:

https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=c40ca7a1bdd93632c6bdc5e23bd33d984d508b19&tochange=a8d497b09753c91783b68c5805c64f34a2f39629

It seems like the bug appeared when tab reordering was introduced.

Comment 9

[knipesteven]

I just tested it again and it doesn't seem to be happening anymore, at least not with the STR that I posted above. I think the UI update with Firefox Quantum fixed the bug.

Comment 10

[Oana Horvath [:ohorvath]]

I was able to reproduce it with the Nightly 63 (2018-07-05) build, on 2 tablets:
Huawei MediaPad M2 (Android 5.1.1)
Samsung Galaxy Tab 3 (Android 7.0)

Comment 11

[Firefox Bug Husbandry Bot]

Re-triaging per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195

Needinfo :susheel if you think this bug should be re-triaged.

Comment 12

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.