Closed
Bug 1382142
Opened 7 years ago
Closed 7 years ago
Fix a typo about MOZ_CONTAINER_GET_CLASS macro
Categories
(Core :: Widget: Gtk, defect)
Core
Widget: Gtk
Tracking
()
RESOLVED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: kenhys, Assigned: kenhys)
Details
Attachments
(1 file)
1.15 KB,
patch
|
karlt
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:54.0) Gecko/20100101 Firefox/54.0
Build ID: 20170616222023
Steps to reproduce:
Checkout latest source.
$ hg clone https://hg.mozilla.org/mozilla-central/ src
$ cd src
$ less widget/gtk/mozcontainer.h
Actual results:
I've found a typo about MOZ_CONTAINER_GET_CLASS macro
diff --git a/widget/gtk/mozcontainer.h b/widget/gtk/mozcontainer.h
--- a/widget/gtk/mozcontainer.h
+++ b/widget/gtk/mozcontainer.h
@@ -46,7 +46,7 @@
#define MOZ_CONTAINER_CLASS(klass) (G_TYPE_CHECK_CLASS_CAST ((klass), MOZ_CONTAINER_TYPE, MozContainerClass))
#define IS_MOZ_CONTAINER(obj) (G_TYPE_CHECK_INSTANCE_TYPE ((obj), MOZ_CONTAINER_TYPE))
#define IS_MOZ_CONTAINER_CLASS(klass) (G_TYPE_CHECK_CLASS_TYPE ((klass), MOZ_CONTAINER_TYPE))
-#define MOZ_CONAINTER_GET_CLASS(obj) (G_TYPE_INSTANCE_GET_CLASS ((obj), MOZ_CONTAINER_TYPE, MozContainerClass))
+#define MOZ_CONTAINER_GET_CLASS(obj) (G_TYPE_INSTANCE_GET_CLASS ((obj), MOZ_CONTAINER_TYPE, MozContainerClass))
Expected results:
It should be MOZ_CONTAINER_GET_CLASS.
There is no side-effects by fixing a typo because this macro definition is
not used in actual implementation.
Assignee | ||
Comment 1•7 years ago
|
||
Comment on attachment 8887838 [details] [diff] [review]
fix-a-typo-moz-container-get-class.patch
Could you review this patch?
Attachment #8887838 -
Flags: review?(karlt)
Updated•7 years ago
|
Attachment #8887838 -
Flags: review?(karlt) → review+
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Updated•7 years ago
|
Assignee: nobody → kenhys
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/41a7b32bdfeb
Fix a typo about MOZ_CONTAINER_GET_CLASS definition. r=karlt
Keywords: checkin-needed
Comment 3•7 years ago
|
||
bugherder |
Status: UNCONFIRMED → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•