1382168 - stylo: MaxLength and MozLength need zero value for SMIL

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P3)

Description

[Hiroyuki Ikezoe (:hiro)]

Emilio noticed that MaxLength does not return zero value [1]

I think we need zero value for MaxLength and MozLength.  Oops Emilio realized that LineHeight have no zero value either.

[1] https://github.com/servo/servo/pull/17774#discussion_r128175751

Comment 1

[Hiroyuki Ikezoe (:hiro)]

Brian? If it's not needed for SMIL, please close this bug.
Thanks!

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Yeah, there are a few of those implementations that seem really dubious... Probably someone should review all of them. I think it'd be nice if only for consistency.

Comment 3

[Brian Birtles (:birtles, Feb 26~ parental leave)]

We don't actually need zero value for most types. It's only used by SMIL and only for properties which are allowed to be animated by SMIL which is a closed set:

  http://searchfox.org/mozilla-central/rev/3a3af33f513071ea829debdfbc628caebcdf6996/dom/smil/nsSMILCSSProperty.cpp#173-227

When I added the zero functionality I probably filled in more types than I needed to simply because some of them were so easy.

Comment 4

[Hiroyuki Ikezoe (:hiro)]

Ok, the list includes 'width' and 'height', so as far as I can tell, we need zero value for MozLength at least.

Comment 5

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Implemented ToAnimatedZero for MozLength in https://github.com/servo/servo/pull/17986