138217 - Quick Launch- switching between POP mail accounts will show folders for both accounts in 3-pane window

Status: VERIFIED FIXED

(MailNews Core :: Backend, defect, P1)

Description

[esther]

Using trunk build 20020416 on winme When switching between Profiles, where the
same mail account is added to each of these Profiles, newly created folders show
up in both Profiles, they should only show up in the Profile from which it was
created. 

1. Launch app with POP mail account, turn Quick Launch on if it isn't already.
2. Create a new folder in your POP account and put a message in it. 
3. Exit app
4. Relaunch with a different profile that contains the same POP account in mail.
5. Create a new folder for that POP account in that profile.  Exit 
6. Relaunch the 1st profile again, go to mail

Result: you will see the folder you create in this account for this profile AND
you will see the folder you created in the same mail account in the 2nd Profile.
Create another new folder, then exit and switch profiles again, you will see the
newly created folders in both Profiles.  Note: the folders listed that were not
created while in that profile will not display the messages or do anything, they
 are just listed.  This could cause some scarry reports of not being able to
open folders or can't read messages in some folders when in reality it's just
because Quick Launch is on.  Turn Quick Launch off and everything is OK, turn it
back on and you will see the confused mail accounts again.  In my opinion, this
could cause some problems when users start reporting in bugs and newsgroups that
some folders are empty or messages can't be read.  Support's first question
should be "Are you in Quick Launch Mode", if so, turn it off.  
Here is a scenario I think could be common among our users:
2 or 3 people share the same computer at home.
Each person creates a Profile and because we support multiple email accounts,
each person puts a work email account in their profile and then adds the
commonly shared ISP mail account in their profile (most likely POP).  Due to
Quick Launch being turned on by default, when each person adds the same ISP POP
account, when they add personal folders to their account in their profile, that
folder will show up in the other persons profile too. That folder is not usable,
can not be deleted, messages can't be dragged into it, and the thread pane
doesn't redraw when the user selects that folder after reading another folder so
it appears there is/are messages in that bogus folder when selected.  
I think this needs to be fixed. nominating nsbeta1

Comment 1

[scottputterman]

reassigning to cavin

Comment 2

[Navin Gupta]

I think this is because we are leaking folder rdf resources. I can take a look 
at this one, if you want cavin.

Comment 3

[Navin Gupta]

Attachment: proposed fix

The fix is to clear mSubFolders array when we are shutting down children
folders also.

Comment 4

[Cavin Song]

Comment on attachment 80496 [details] [diff] [review]
proposed fix

r=cavin.

Comment 5

[Navin Gupta]

David, can you sr? thanks.

The rdf service maintains a hashtable so it will return the old root folder, hence
it is necessary to clear the subfolders. 

Comment 6

[scottputterman]

marking [adt1 rtm].  This is not a beta stop ship bug.  Let's get this in for rtm.

Comment 7

[David :Bienvenu]

Comment on attachment 80496 [details] [diff] [review]
proposed fix

the comment is wrong. "will come here if shutDownChildren is true" We will
always come here if we call shutdown on a folder. A more accurate and appropros
comment might be "we will come here after we've shutdown the children, when
shutDownChildren is true" Please fix the comment, and sr=bienvenu

Comment 8

[Navin Gupta]

I would suggest you to reconsider because all the user defined folders 
from the acct in one profile show up in the other profile. This is really
bad. 

I discussed with david and my comment is ok. 

Comment 9

[Navin Gupta]

fixed

Comment 10

[scottputterman]

making nsbeta1- since Quick Launch is turned off for multiple profiles.

Comment 11

[esther]

This bug is fixed in current branch build 20020602  1.0.0.  I'm not sure if the
fix is due to the new turbo model (see bug bug 98673) or if Navin checked his
into a branch build.

Comment 12

[David :Bienvenu]

I had to check his fix into the branch to fix another bug. So this fix is on the
branch, and this bug is fixed on the branch.

Comment 13

[esther]

verified