Closed
Bug 1382196
Opened 7 years ago
Closed 7 years ago
Use the prefs defined in TelemetryUtils.jsm in TelemetryReportingPolicy.jsm
Categories
(Toolkit :: Telemetry, enhancement, P1)
Toolkit
Telemetry
Tracking
()
RESOLVED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: alejandro, Assigned: alejandro, Mentored)
References
(Blocks 1 open bug)
Details
(Whiteboard: [measurement:client])
Attachments
(1 file)
10.49 KB,
patch
|
Dexter
:
review+
|
Details | Diff | Splinter Review |
We should change Telemetry code to use the preferences defined in the TelemetryUtils.jsm file rather than redefining them in TelemetryReportingPolicy.jsm.
Assignee | ||
Updated•7 years ago
|
Whiteboard: [measurement:client]
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → alexrs95
Assignee | ||
Comment 1•7 years ago
|
||
Attachment #8890354 -
Flags: review?(alessio.placitelli)
Comment 2•7 years ago
|
||
Comment on attachment 8890354 [details] [diff] [review] Use the prefs defined in TelemetryUtils.jsm in TelemetryReportingPolicy.jsm Review of attachment 8890354 [details] [diff] [review]: ----------------------------------------------------------------- This looks good with the nit below addressed. ::: toolkit/components/telemetry/TelemetryUtils.jsm @@ +49,5 @@ > CurrentPolicyVersion: "datareporting.policy.currentPolicyVersion", > DataSubmissionEnabled: "datareporting.policy.dataSubmissionEnabled", > FhrUploadEnabled: "datareporting.healthreport.uploadEnabled", > MinimumPolicyVersion: "datareporting.policy.minimumPolicyVersion", > + FirstRunURL: "datareporting.policy.firstRunURL", Can you move this one near FirstRun?
Attachment #8890354 -
Flags: review?(alessio.placitelli) → feedback+
Assignee | ||
Comment 3•7 years ago
|
||
(In reply to Alessio Placitelli [:Dexter] from comment #2) > Comment on attachment 8890354 [details] [diff] [review] > Use the prefs defined in TelemetryUtils.jsm in TelemetryReportingPolicy.jsm > > Review of attachment 8890354 [details] [diff] [review]: > ----------------------------------------------------------------- > > This looks good with the nit below addressed. > > ::: toolkit/components/telemetry/TelemetryUtils.jsm > @@ +49,5 @@ > > CurrentPolicyVersion: "datareporting.policy.currentPolicyVersion", > > DataSubmissionEnabled: "datareporting.policy.dataSubmissionEnabled", > > FhrUploadEnabled: "datareporting.healthreport.uploadEnabled", > > MinimumPolicyVersion: "datareporting.policy.minimumPolicyVersion", > > + FirstRunURL: "datareporting.policy.firstRunURL", > > Can you move this one near FirstRun? Now the prefs are ordered by branch name. "toolkit.telemetry.*" first, then "datareporting.policy.*". FirstRun belongs to the first group, and FirstRunURL to the second one. Should I break this order to move FirstRunURL near FirstRun?
Updated•7 years ago
|
Attachment #8890354 -
Flags: feedback+ → review+
Comment 4•7 years ago
|
||
(In reply to Alejandro Rodriguez Salamanca from comment #3) > (In reply to Alessio Placitelli [:Dexter] from comment #2) > > Comment on attachment 8890354 [details] [diff] [review] > > Use the prefs defined in TelemetryUtils.jsm in TelemetryReportingPolicy.jsm > > > > Review of attachment 8890354 [details] [diff] [review]: > > ----------------------------------------------------------------- > > > > This looks good with the nit below addressed. > > > > ::: toolkit/components/telemetry/TelemetryUtils.jsm > > @@ +49,5 @@ > > > CurrentPolicyVersion: "datareporting.policy.currentPolicyVersion", > > > DataSubmissionEnabled: "datareporting.policy.dataSubmissionEnabled", > > > FhrUploadEnabled: "datareporting.healthreport.uploadEnabled", > > > MinimumPolicyVersion: "datareporting.policy.minimumPolicyVersion", > > > + FirstRunURL: "datareporting.policy.firstRunURL", > > > > Can you move this one near FirstRun? > > Now the prefs are ordered by branch name. "toolkit.telemetry.*" first, then > "datareporting.policy.*". FirstRun belongs to the first group, and > FirstRunURL to the second one. Should I break this order to move FirstRunURL > near FirstRun? Nope, good point.
Comment 5•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4cced594a1e875a71f37e5f780b2a09e90ecd6f5
Comment 6•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/a86a44628486dbe2f350ce6bbdf86564d1fa32d9 Bug 1382196 - Use the prefs defined in TelemetryUtils.jsm in TelemetryReportingPolicy.jsm. r=dexter
Comment 7•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a86a44628486
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•