Clean up IsScrollInfoLayer functions

RESOLVED FIXED in Firefox 56

Status

()

P3
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: kats, Assigned: kats)

Tracking

unspecified
mozilla56
Points:
---

Firefox Tracking Flags

(firefox56 fixed)

Details

(Whiteboard: [gfx-noted])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(3 attachments)

There's a IsScrollInfoLayer function in LayerMetricsWrapper/WebRenderScrollDataWrapper which uses the "complicated" check to determine if the metrics is for a scrollinfo layer. The "complicated" check is the one used in Layer::IsScrollInfoLayer [1]. Instead, it could use the much simpler check from FrameMetrics::IsScrollInfoLayer [2]. The reason it doesn't do so already is that the simpler FrameMetrics function was added later. However, the two should be equivalent.

There are a couple of call sites that still call Layer::IsScrollInfoLayer and I'd like to rename that function also to better reflect what the call sites really want to be checking for.

The main driver for doing this is that the less layers-specific stuff we have in WebRenderScrollData, the easier it is to hook up APZ to layers-free webrender.

[1] http://searchfox.org/mozilla-central/rev/88180977d79654af025158d8ebeb8c2aa11940eb/gfx/layers/Layers.cpp#670
[2] http://searchfox.org/mozilla-central/rev/88180977d79654af025158d8ebeb8c2aa11940eb/gfx/layers/FrameMetrics.h#491
Priority: -- → P3
Whiteboard: [gfx-noted]
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 5

a year ago
mozreview-review
Comment on attachment 8887912 [details]
Bug 1382200 - Rename Layer::IsScrollInfoLayer to better capture what the call sites care about.

https://reviewboard.mozilla.org/r/158824/#review164238
Attachment #8887912 - Flags: review?(botond) → review+

Comment 6

a year ago
mozreview-review
Comment on attachment 8887913 [details]
Bug 1382200 - Change implementation of the LayerMetricsWrapper IsScrollInfoLayer to use the metrics flag.

https://reviewboard.mozilla.org/r/158826/#review164240
Attachment #8887913 - Flags: review?(botond) → review+

Comment 7

a year ago
mozreview-review
Comment on attachment 8887914 [details]
Bug 1382200 - Eliminate LayerMetricsWrapper::IsScrollInfoLayer entirely by inlining it.

https://reviewboard.mozilla.org/r/158828/#review164242
Attachment #8887914 - Flags: review?(botond) → review+

Comment 8

a year ago
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/90b186b95d75
Rename Layer::IsScrollInfoLayer to better capture what the call sites care about. r=botond
https://hg.mozilla.org/integration/autoland/rev/d6f3312bc785
Change implementation of the LayerMetricsWrapper IsScrollInfoLayer to use the metrics flag. r=botond
https://hg.mozilla.org/integration/autoland/rev/46fb0382583c
Eliminate LayerMetricsWrapper::IsScrollInfoLayer entirely by inlining it. r=botond

Comment 9

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/90b186b95d75
https://hg.mozilla.org/mozilla-central/rev/d6f3312bc785
https://hg.mozilla.org/mozilla-central/rev/46fb0382583c
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.