1382201 - Use the prefs defined in TelemetryUtils.jsm in TelemetryArchive.jsm

Status: RESOLVED FIXED

(Toolkit :: Telemetry, enhancement, P1)

Description

[Alejandro Rodriguez Salamanca [:alejandro]]

We should change Telemetry code to use the preferences defined in the TelemetryUtils.jsm file rather than redefining them in TelemetryArchive.jsm

Comment 1

[Alejandro Rodriguez Salamanca [:alejandro]]

Attachment: Use the prefs defined in TelemetryUtils.jsm in TelemetryArchive.jsm

Comment 2

[Alessio Placitelli [:Dexter]]

Comment on attachment 8887942 [details] [diff] [review]
Use the prefs defined in TelemetryUtils.jsm in TelemetryArchive.jsm

Review of attachment 8887942 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/telemetry/TelemetryArchive.jsm
@@ +14,5 @@
>  Cu.import("resource://gre/modules/XPCOMUtils.jsm", this);
>  Cu.import("resource://gre/modules/Preferences.jsm", this);
>  Cu.import("resource://gre/modules/osfile.jsm", this);
> +Cu.import("resource://gre/modules/TelemetryUtils.jsm", this);
> +Cu.import("resource://gre/modules/TelemetryUtils.jsm", this);

You're importing this twice. Please remove one of the two lines.

Comment 3

[Alejandro Rodriguez Salamanca [:alejandro]]

Attachment: Use the prefs defined in TelemetryUtils.jsm in TelemetryArchive.jsm

Comment 4

[Alessio Placitelli [:Dexter]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=baa3e00e264134e53070c962b0dccdce1e620071

Comment 5

[Alessio Placitelli [:Dexter]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3b29f600411fcfdab16a161196fef7749cae1803
Bug 1382201 - Use the prefs defined in TelemetryUtils.jsm in TelemetryArchive.jsm. r=dexter

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/3b29f600411f