Rendering issues for phonebook

VERIFIED FIXED in Firefox 55

Status

()

VERIFIED FIXED
a year ago
a year ago

People

(Reporter: TheOne, Assigned: u459114)

Tracking

({regression, regressionwindow-wanted})

55 Branch
mozilla56
regression, regressionwindow-wanted
Points:
---

Firefox Tracking Flags

(firefox-esr52 unaffected, firefox54 unaffected, firefox55 fixed, firefox56 fixed)

Details

(Whiteboard: [gfx-noted], URL)

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(3 attachments)

(Reporter)

Description

a year ago
Created attachment 8887970 [details]
phonebook-issue.png

There seems to be an issue in Nightly where some elements are not rendered correctly.

It doesn't occur for every page, but I could reliably reproduce it for the one provided in the URL field. You might have to hard-reload the page in order to see it.
(Reporter)

Comment 1

a year ago
Ah, I forgot to mention, switching to another tab and back "fixes" the issue.
Is this a regression? i.e. can you reproduce the problem on Release?
Flags: needinfo?(awagner)
(Reporter)

Comment 3

a year ago
Oops sorry, I had tested that but forgot to mention it.

I cannot reproduce on Release, so it seems to be a regression.
Flags: needinfo?(awagner)
Keywords: regressionwindow-wanted
Keywords: regression
Andreas - what's your platform?  about:support graphics section would do it.
Flags: needinfo?(awagner)
Whiteboard: [gfx-noted]
(Reporter)

Comment 5

a year ago
Application Basics
------------------

Name: Firefox
Version: 56.0a1
Build ID: 20170720100139
Update Channel: nightly
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:56.0) Gecko/20100101 Firefox/56.0
OS: Darwin 16.7.0
Multiprocess Windows: 1/1 (Enabled by default)
Web Content Processes: 4/4
Stylo: false (disabled by default)
Google Key: Found
Mozilla Location Service Key: Found
Safe Mode: false

Graphics
--------

Features
Compositing: OpenGL
Asynchronous Pan/Zoom: wheel input enabled; scrollbar drag enabled
WebGL 1 Driver WSI Info: CGL
WebGL 1 Driver Renderer: ATI Technologies Inc. -- AMD Radeon R9 M370X OpenGL Engine
WebGL 1 Driver Version: 2.1 ATI-1.51.8
WebGL 1 Driver Extensions: GL_ARB_color_buffer_float GL_ARB_depth_buffer_float GL_ARB_depth_clamp GL_ARB_depth_texture GL_ARB_draw_buffers GL_ARB_draw_elements_base_vertex GL_ARB_draw_instanced GL_ARB_fragment_program GL_ARB_fragment_program_shadow GL_ARB_fragment_shader GL_ARB_framebuffer_object GL_ARB_framebuffer_sRGB GL_ARB_half_float_pixel GL_ARB_half_float_vertex GL_ARB_imaging GL_ARB_instanced_arrays GL_ARB_multisample GL_ARB_multitexture GL_ARB_occlusion_query GL_ARB_pixel_buffer_object GL_ARB_point_parameters GL_ARB_point_sprite GL_ARB_provoking_vertex GL_ARB_seamless_cube_map GL_ARB_shader_objects GL_ARB_shader_texture_lod GL_ARB_shading_language_100 GL_ARB_shadow GL_ARB_shadow_ambient GL_ARB_sync GL_ARB_texture_border_clamp GL_ARB_texture_compression GL_ARB_texture_compression_rgtc GL_ARB_texture_cube_map GL_ARB_texture_env_add GL_ARB_texture_env_combine GL_ARB_texture_env_crossbar GL_ARB_texture_env_dot3 GL_ARB_texture_float GL_ARB_texture_mirrored_repeat GL_ARB_texture_non_power_of_two GL_ARB_texture_rectangle GL_ARB_texture_rg GL_ARB_transpose_matrix GL_ARB_vertex_array_bgra GL_ARB_vertex_blend GL_ARB_vertex_buffer_object GL_ARB_vertex_program GL_ARB_vertex_shader GL_ARB_window_pos GL_EXT_abgr GL_EXT_bgra GL_EXT_bindable_uniform GL_EXT_blend_color GL_EXT_blend_equation_separate GL_EXT_blend_func_separate GL_EXT_blend_minmax GL_EXT_blend_subtract GL_EXT_clip_volume_hint GL_EXT_debug_label GL_EXT_debug_marker GL_EXT_depth_bounds_test GL_EXT_draw_buffers2 GL_EXT_draw_range_elements GL_EXT_fog_coord GL_EXT_framebuffer_blit GL_EXT_framebuffer_multisample GL_EXT_framebuffer_object GL_EXT_framebuffer_sRGB GL_EXT_geometry_shader4 GL_EXT_gpu_program_parameters GL_EXT_gpu_shader4 GL_EXT_multi_draw_arrays GL_EXT_packed_depth_stencil GL_EXT_packed_float GL_EXT_provoking_vertex GL_EXT_rescale_normal GL_EXT_secondary_color GL_EXT_separate_specular_color GL_EXT_shadow_funcs GL_EXT_stencil_two_side GL_EXT_stencil_wrap GL_EXT_texture_array GL_EXT_texture_compression_dxt1 GL_EXT_texture_compression_s3tc GL_EXT_texture_env_add GL_EXT_texture_filter_anisotropic GL_EXT_texture_integer GL_EXT_texture_lod_bias GL_EXT_texture_mirror_clamp GL_EXT_texture_rectangle GL_EXT_texture_shared_exponent GL_EXT_texture_sRGB GL_EXT_texture_sRGB_decode GL_EXT_timer_query GL_EXT_transform_feedback GL_EXT_vertex_array_bgra GL_APPLE_aux_depth_stencil GL_APPLE_client_storage GL_APPLE_element_array GL_APPLE_fence GL_APPLE_float_pixels GL_APPLE_flush_buffer_range GL_APPLE_flush_render GL_APPLE_object_purgeable GL_APPLE_packed_pixels GL_APPLE_pixel_buffer GL_APPLE_rgb_422 GL_APPLE_row_bytes GL_APPLE_specular_vector GL_APPLE_texture_range GL_APPLE_transform_hint GL_APPLE_vertex_array_object GL_APPLE_vertex_array_range GL_APPLE_vertex_point_size GL_APPLE_vertex_program_evaluators GL_APPLE_ycbcr_422 GL_ATI_blend_equation_separate GL_ATI_blend_weighted_minmax GL_ATI_separate_stencil GL_ATI_texture_compression_3dc GL_ATI_texture_env_combine3 GL_ATI_texture_float GL_ATI_texture_mirror_once GL_IBM_rasterpos_clip GL_NV_blend_square GL_NV_conditional_render GL_NV_depth_clamp GL_NV_fog_distance GL_NV_light_max_exponent GL_NV_texgen_reflection GL_NV_texture_barrier GL_SGI_color_matrix GL_SGIS_generate_mipmap GL_SGIS_texture_edge_clamp GL_SGIS_texture_lod
WebGL 1 Extensions: ANGLE_instanced_arrays EXT_blend_minmax EXT_color_buffer_half_float EXT_frag_depth EXT_sRGB EXT_shader_texture_lod EXT_texture_filter_anisotropic MOZ_debug OES_element_index_uint OES_standard_derivatives OES_texture_float OES_texture_float_linear OES_texture_half_float OES_texture_half_float_linear OES_vertex_array_object WEBGL_color_buffer_float WEBGL_compressed_texture_s3tc WEBGL_compressed_texture_s3tc_srgb WEBGL_debug_renderer_info WEBGL_debug_shaders WEBGL_depth_texture WEBGL_draw_buffers WEBGL_lose_context MOZ_WEBGL_lose_context MOZ_WEBGL_compressed_texture_s3tc MOZ_WEBGL_depth_texture
WebGL 2 Driver WSI Info: CGL
WebGL 2 Driver Renderer: ATI Technologies Inc. -- AMD Radeon R9 M370X OpenGL Engine
WebGL 2 Driver Version: 4.1 ATI-1.51.8
WebGL 2 Driver Extensions: GL_ARB_blend_func_extended GL_ARB_draw_buffers_blend GL_ARB_draw_indirect GL_ARB_ES2_compatibility GL_ARB_explicit_attrib_location GL_ARB_gpu_shader_fp64 GL_ARB_gpu_shader5 GL_ARB_instanced_arrays GL_ARB_internalformat_query GL_ARB_occlusion_query2 GL_ARB_sample_shading GL_ARB_sampler_objects GL_ARB_separate_shader_objects GL_ARB_shader_bit_encoding GL_ARB_shader_subroutine GL_ARB_shading_language_include GL_ARB_tessellation_shader GL_ARB_texture_buffer_object_rgb32 GL_ARB_texture_cube_map_array GL_ARB_texture_gather GL_ARB_texture_query_lod GL_ARB_texture_rgb10_a2ui GL_ARB_texture_storage GL_ARB_texture_swizzle GL_ARB_timer_query GL_ARB_transform_feedback2 GL_ARB_transform_feedback3 GL_ARB_vertex_attrib_64bit GL_ARB_vertex_type_2_10_10_10_rev GL_ARB_viewport_array GL_EXT_debug_label GL_EXT_debug_marker GL_EXT_depth_bounds_test GL_EXT_texture_compression_s3tc GL_EXT_texture_filter_anisotropic GL_EXT_texture_mirror_clamp GL_EXT_texture_sRGB_decode GL_APPLE_client_storage GL_APPLE_container_object_shareable GL_APPLE_flush_render GL_APPLE_object_purgeable GL_APPLE_rgb_422 GL_APPLE_row_bytes GL_APPLE_texture_range GL_ATI_texture_mirror_once GL_NV_texture_barrier
WebGL 2 Extensions: EXT_color_buffer_float EXT_texture_filter_anisotropic EXT_disjoint_timer_query MOZ_debug OES_texture_float_linear WEBGL_compressed_texture_s3tc WEBGL_debug_renderer_info WEBGL_debug_shaders WEBGL_lose_context MOZ_WEBGL_lose_context MOZ_WEBGL_compressed_texture_s3tc
Audio Backend: audiounit
GPU #1
Active: Yes
Vendor ID: 0x8086
Device ID: 0x0d26

Diagnostics
AzureCanvasAccelerated: 1
AzureCanvasBackend: skia
AzureContentBackend: skia
AzureFallbackCanvasBackend: none
TileHeight: 1024
TileWidth: 1024
Decision Log
WEBRENDER:
opt-in by default: WebRender is an opt-in feature
Flags: needinfo?(awagner)
Thanks.  I see it on Win 10 as well, and mozregression seems to point to bug 1359844.
Blocks: 1359844
Flags: needinfo?(cku)
Component: Graphics → Layout: View Rendering
Comment hidden (mozreview-request)
(Assignee)

Updated

a year ago
Assignee: nobody → cku
Flags: needinfo?(cku)
(Assignee)

Updated

a year ago
Attachment #8888595 - Flags: review?(mstange)

Comment 8

a year ago
mozreview-review
Comment on attachment 8888595 [details]
Bug 1382257 - Correct returning value of PaintBorderWithStyleBorder.

https://reviewboard.mozilla.org/r/159584/#review164986
Attachment #8888595 - Flags: review?(mstange) → review+
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 12

a year ago
Pushed by cku@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/499d18aed4f0
Correct returning value of PaintBorderWithStyleBorder. r=mstange

Comment 13

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/499d18aed4f0
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
(Reporter)

Comment 14

a year ago
I can still reproduce the issue in 20170723100358.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 15

a year ago
hi Andeas,
"You might have to hard-reload the page in order to see it"
May I know is that mean "clean all data" in option page?
Flags: needinfo?(awagner)
(Reporter)

Comment 16

a year ago
No, I just have to click Shift+Reload button.
Flags: needinfo?(awagner)

Updated

a year ago
status-firefox55: --- → affected
status-firefox56: fixed → affected
(Assignee)

Comment 18

a year ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/12a1858f250b2b206ba0640cead2945fce97695e
Bug 1382257 - (followup) Draw border image if nsCSSBorderImageRenderer was created successfully. r=me.

Comment 19

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/12a1858f250b
Status: REOPENED → RESOLVED
Last Resolved: a year agoa year ago
status-firefox56: affected → fixed
Resolution: --- → FIXED
This does fix the problem for me.
(Reporter)

Comment 21

a year ago
Wfm too. Thank you for fixing this!
Status: RESOLVED → VERIFIED
uplift request to beta, please.
Flags: needinfo?(cku)
status-firefox54: --- → unaffected
status-firefox-esr52: --- → unaffected
Version: Trunk → 55 Branch
If you're going to request uplift it would have to be soon, we're merging to release and building rc on monday
(Assignee)

Comment 24

a year ago
Created attachment 8891291 [details] [diff] [review]
patch for beta
Flags: needinfo?(cku)
(Assignee)

Comment 25

a year ago
Comment on attachment 8891291 [details] [diff] [review]
patch for beta

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1359844
[User impact if declined]: may not see border-image
[Is this code covered by automated tests?]:no
[Has the fix been verified in Nightly?]:yes
[Needs manual test from QE? If yes, steps to reproduce]: no. I aleady verified by access "https://phonebook.mozilla.org/?search/bryan"
[List of other uplifts needed for the feature/fix]: only this one
[Is the change risky?]:no
[Why is the change risky/not risky?]: small change
[String changes made/needed]:N/A
Attachment #8891291 - Flags: approval-mozilla-beta?
Comment on attachment 8891291 [details] [diff] [review]
patch for beta

fix a rendering regression with border-image, beta55+

should be in 55.0 rc1
Attachment #8891291 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Comment 27

a year ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-beta/rev/b28e95b7acac
status-firefox55: affected → fixed
You need to log in before you can comment on or make changes to this bug.