Open Bug 1382274 Opened 3 years ago Updated 2 years ago

Get the correct active tab notification from inside Gecko

Categories

(Core :: Networking, enhancement, P2)

enhancement

Tracking

()

Tracking Status
fennec ? ---

People

(Reporter: mayhemer, Assigned: kershaw)

References

(Blocks 1 open bug)

Details

(Whiteboard: [necko-triaged])

Based on chat with Dao.

In bug 1366822 we are introducing a patch that uses front end to notify necko about the active tab.  We know that using nsFocusManager [1], bug 1309653, is broken at this, so the best way is to use the same source of information NetworkPrioritizer.jsm was using, directly from inside Gecko.

This bug is about finding that place in Gecko, revert patch for bug 1366822 and implement it correctly.

[1] https://bugzilla.mozilla.org/attachment.cgi?id=8845809&action=diff
(In reply to Honza Bambas (:mayhemer) from comment #0)
> Based on chat with Dao.
> 
> In bug 1366822 we are introducing a patch that uses front end to notify
> necko about the active tab.  We know that using nsFocusManager [1], bug
> 1309653, is broken at this, so the best way is to use the same source of
> information NetworkPrioritizer.jsm was using, directly from inside Gecko.
> 
> This bug is about finding that place in Gecko, revert patch for bug 1366822
> and implement it correctly.
> 
> [1] https://bugzilla.mozilla.org/attachment.cgi?id=8845809&action=diff

I am not quite sure what's the difference between this bug and bug 1366822.

Does this bug tend to revert the changes done in bug 1309653? Like the part2 patch I uploaded in [1]?
If yes, I think we should put the patch in bug 1366822 because the front-end code and the reversing patch should be landed at the same time.

[1] https://bug1366822.bmoattachments.org/attachment.cgi?id=8884205
Flags: needinfo?(honzab.moz)
Clear the ni since I already got the answer I want.
Flags: needinfo?(honzab.moz)
Assignee: nobody → kechang
Whiteboard: [necko-next]
Bulk change to priority: https://bugzilla.mozilla.org/show_bug.cgi?id=1399258
Priority: P5 → P2
Priority: P2 → P4
Honza, there's no such thing as P4.  It's a myth :)
Priority: P4 → P3
Blocks: 1467755
This turns out to be important for mobile (android) since there we are not receiving the tab change notification at all (current tab remains 0) which breaks few things (background prioritization, throttling), sometimes with bad user impact.
Priority: P3 → P2
Whiteboard: [necko-next] → [necko-triaged]
tracking-fennec: --- → ?
You need to log in before you can comment on or make changes to this bug.