Closed Bug 1382304 Opened 8 years ago Closed 8 years ago

hgignore captures/ directory

Categories

(Firefox Build System :: Android Studio and Gradle Integration, enhancement, P1)

Product:
Firefox Build System
Component:
Android Studio and Gradle Integration
Platform:
All
Android
Type:
enhancement

Tracking

(firefox56 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla56
Iteration:
1.26
Tracking Flags:
Tracking Status
firefox56 --- fixed

People

(Reporter: mcomella, Assigned: mcomella)

Details

(Whiteboard: [mobileAS] 1.26)

Attachments

(1 file)

Bug 1382304: hg/gitignore captures/ dir.
59 bytes, text/x-review-board-request
nalexander
: review+
Details
I've been using the Android Monitor in Android Studio and it's created a "<m-c>/captures/..." directory. Example hg status: M mobile/android/base/java/org/mozilla/gecko/activitystream/homepanel/stream/HighlightItem.java ? captures/org.mozilla.fennec_mcomella_2017.07.18_16.48.txt ? captures/org.mozilla.fennec_mcomella_2017.07.18_16.52.hprof ? captures/org.mozilla.fennec_mcomella_2017.07.18_17.27.hprof We should ignore captures/ so these files don't get added to v-c.
Comment on attachment 8888004 [details] Bug 1382304: hg/gitignore captures/ dir. https://reviewboard.mozilla.org/r/158884/#review164282 I'd prefer not to do this, since `captures/` is a top-level directory, not a dot file, and is a conceivable name for Gecko/Firefox functionality. However, there is precedent (`infer-out`) and https://stackoverflow.com/a/31996453 is not pleasant en masse.
Attachment #8888004 - Flags: review?(nalexander) → review+
Pushed by michael.l.comella@gmail.com: https://hg.mozilla.org/integration/autoland/rev/4a7dd8750616 hg/gitignore captures/ dir. r=nalexander
https://hg.mozilla.org/mozilla-central/rev/4a7dd8750616
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
Whiteboard: [mobileAS] 1.26
Iteration: --- → 1.26
Priority: -- → P1
Product: Firefox for Android → Firefox Build System
Target Milestone: Firefox 56 → mozilla56
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: