Closed
Bug 1382327
Opened 7 years ago
Closed 7 years ago
(reftest) Change reftest-print to reftest-paged
Categories
(Testing :: Reftest, enhancement)
Testing
Reftest
Tracking
(firefox56 fixed)
RESOLVED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: tschneider, Assigned: tschneider)
References
Details
Attachments
(1 file, 3 obsolete files)
272.06 KB,
patch
|
Details | Diff | Splinter Review |
Based on discussions in Bug 1299848, reftest-print should be renamed to reftest-paged, cause testing pagination is what those test are actually doing. This will avoid confusion with real printing reftests.
Assignee | ||
Updated•7 years ago
|
Summary: Change reftest-print to reftest-paged → (reftest) Change reftest-print to reftest-paged
Assignee | ||
Comment 1•7 years ago
|
||
Assignee | ||
Comment 2•7 years ago
|
||
Rebased patch
Assignee | ||
Updated•7 years ago
|
Attachment #8888012 -
Attachment is obsolete: true
Assignee | ||
Comment 3•7 years ago
|
||
Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=deccda7fcd34b9513cc08907bb53612c89ac1aa6
Assignee | ||
Comment 5•7 years ago
|
||
New try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f53984f453c5a0d2fb8e813ac7404b7aef034617
Assignee | ||
Comment 6•7 years ago
|
||
Comment on attachment 8889263 [details] [diff] [review] Rename reftest-print to reftest-paged David, as suggested in https://bugzilla.mozilla.org/show_bug.cgi?id=1299848#c23, the first step before landing bug 1299848 should be renaming the existing reftest-print to reftest-paged to avoid confusion. This patch is mostly doing that. only code change is https://bugzilla.mozilla.org/attachment.cgi?id=8889263&action=diff#a/layout/tools/reftest/reftest-content.js_sec2 which throws if previous naming is being used.
Attachment #8889263 -
Flags: review?(dbaron)
Comment on attachment 8889263 [details] [diff] [review] Rename reftest-print to reftest-paged >+ if (classList.indexOf("reftest-print") > -1) { Please use "!= -1" rather than "> -1" You've also made encoding changes in these tests: layout/base/crashtests/363729-2.html layout/base/crashtests/363729-3.html layout/generic/crashtests/570160.html Please revert those character encoding changes. r=dbaron with that
Attachment #8889263 -
Flags: review?(dbaron) → review+
Assignee | ||
Comment 8•7 years ago
|
||
Addressed review comments.
Attachment #8889263 -
Attachment is obsolete: true
Assignee | ||
Comment 9•7 years ago
|
||
Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=46237912d7e4cbb70e3df17e8555a5d3ad559b49
Comment 10•7 years ago
|
||
Pushed by tschneider@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/c5acd94ff501 (reftest) Rename reftest-print to reftest-paged. r=dbaron
Could you email dev-tech-layout (or maybe dev-platform?) to say this happened?
Flags: needinfo?(tschneider)
Comment 12•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/c5acd94ff501
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Assignee | ||
Comment 13•7 years ago
|
||
(In reply to David Baron :dbaron: ⌚️UTC+1 from comment #11) > Could you email dev-tech-layout (or maybe dev-platform?) to say this > happened? Done.
Flags: needinfo?(tschneider)
Updated•7 years ago
|
Assignee: nobody → tschneider
Component: Printing: Output → Reftest
Product: Core → Testing
Version: unspecified → Trunk
Comment 14•7 years ago
|
||
dev-platform post: https://groups.google.com/forum/#!topic/mozilla.dev.platform/tnVjsaXkOGE
You need to log in
before you can comment on or make changes to this bug.
Description
•