1382327 - (reftest) Change reftest-print to reftest-paged

Status: RESOLVED FIXED

(Testing :: Reftest, enhancement)

Description

[Tobias Schneider [:tobytailor]]

Based on discussions in Bug 1299848, reftest-print should be renamed to reftest-paged, cause testing pagination is what those test are actually doing. This will avoid confusion with real printing reftests.

Comment 1

[Tobias Schneider [:tobytailor]]

Attachment: Rename reftest-print to reftest-paged

Comment 2

[Tobias Schneider [:tobytailor]]

Attachment: Rename reftest-print to reftest-paged

Rebased patch

Comment 3

[Tobias Schneider [:tobytailor]]

Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=deccda7fcd34b9513cc08907bb53612c89ac1aa6

Comment 4

[Tobias Schneider [:tobytailor]]

Attachment: Rename reftest-print to reftest-paged

Updated patch

Comment 5

[Tobias Schneider [:tobytailor]]

New try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f53984f453c5a0d2fb8e813ac7404b7aef034617

Comment 6

[Tobias Schneider [:tobytailor]]

Comment on attachment 8889263 [details] [diff] [review]
Rename reftest-print to reftest-paged

David, as suggested in https://bugzilla.mozilla.org/show_bug.cgi?id=1299848#c23, the first step before landing bug 1299848 should be renaming the existing reftest-print to reftest-paged to avoid confusion. This patch is mostly doing that. only code change is https://bugzilla.mozilla.org/attachment.cgi?id=8889263&action=diff#a/layout/tools/reftest/reftest-content.js_sec2 which throws if previous naming is being used.

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 8889263 [details] [diff] [review]
Rename reftest-print to reftest-paged

>+        if (classList.indexOf("reftest-print") > -1) {

Please use "!= -1" rather than "> -1"



You've also made encoding changes in these tests:
layout/base/crashtests/363729-2.html
layout/base/crashtests/363729-3.html
layout/generic/crashtests/570160.html

Please revert those character encoding changes.


r=dbaron with that

Comment 8

[Tobias Schneider [:tobytailor]]

Attachment: Rename reftest-print to reftest-paged. r=dbaron

Addressed review comments.

Comment 9

[Tobias Schneider [:tobytailor]]

Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=46237912d7e4cbb70e3df17e8555a5d3ad559b49

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c5acd94ff501
(reftest) Rename reftest-print to reftest-paged. r=dbaron

Comment 11

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Could you email dev-tech-layout (or maybe dev-platform?) to say this happened?

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c5acd94ff501

Comment 13

[Tobias Schneider [:tobytailor]]

(In reply to David Baron :dbaron: ⌚️UTC+1 from comment #11)
> Could you email dev-tech-layout (or maybe dev-platform?) to say this
> happened?

Done.

Comment 14

[Brian Birtles (:birtles)]

dev-platform post:
https://groups.google.com/forum/#!topic/mozilla.dev.platform/tnVjsaXkOGE