1382346 - Allow original error message to bubble up in telemetry harness

Status: NEW

(Toolkit :: Telemetry, enhancement, P4)

Description

[John Dorlus [:Silne30]]

The harness is swallowing the original error message in testcase.py.

Comment 1

[John Dorlus [:Silne30]]

Attachment: Bug 1382346 - Raised original exception when ping fails to come in

Instead of swallowing the error message, I raised the error when caught.

Review commit: https://reviewboard.mozilla.org/r/161722/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/161722/

Comment 2

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Comment on attachment 8890574 [details]
Bug 1382346 - Raised original exception when ping fails to come in

https://reviewboard.mozilla.org/r/161722/#review167930

r+wc

::: toolkit/components/telemetry/tests/marionette/harness/telemetry_harness/testcase.py:56
(Diff revision 1)
>              try:
>                  Wait(self.marionette, 60).until(lambda t: len(self.ping_list) > 0)
>              except Exception as e:
> -                self.fail('Error generating ping: {}'.format(e.message))
> +                raise e

Remove the try-except block entirely. Instead, call `until` with a `message` kwarg that describes what the exception likely represents: e.g. `Wait(...).until(..., message="Error generating ping: ...")`

Comment 3

[John Dorlus [:Silne30]]

Comment on attachment 8890574 [details]
Bug 1382346 - Raised original exception when ping fails to come in

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/161722/diff/1-2/