Closed Bug 1382450 Opened 2 years ago Closed 2 years ago
enable pref "dom
.meta-viewport .enabled" for Math ML font-inflation-1 .html reftest
Bug 1382450: Turn on pref "dom.meta-viewport.enabled" for MathML reftest "font-inflation-1.html", like we do for other font-inflation reftests.
59 bytes, text/x-review-board-request
My initial landing of bug 1373767 triggered a test failure in layout/reftests/mathml/font-inflation-1.html, but only on Android. The test passes reliably on other platforms, but that's just because it's not actually testing anything. It turns out font inflation depends on whether <meta viewport> is enabled (and it's enabled by default on android, but not on other platforms). For all other font inflation reftests, we seem to enable the "dom.meta-viewport.enabled" pref (so that they behave consistently across platforms). And if I make that change locally, then this test starts behaving like I'd expect (rendering text at larger sizes, and failing like it did on Android if I apply my patch from bug 1373767). So let's add that pref annotation, for consistency & better platform-independent runnability of this test.
Note: here's where we set that pref (as a blanket enabling) for the other font inflation reftests: https://dxr.mozilla.org/mozilla-central/rev/1b065ffd8a535a0ad4c39a912af18e948e6a42c1/layout/reftests/font-inflation/reftest.list#9-12 ...and we set it here for a font inflation + ruby reftest (along with some other prefs that don't seem to be necessary for this mathml case): https://dxr.mozilla.org/mozilla-central/rev/1b065ffd8a535a0ad4c39a912af18e948e6a42c1/layout/reftests/css-ruby/reftest.list#19
Try run (which shows some extra csets being pushed because it was based on inbound tip): https://treeherder.mozilla.org/#/jobs?repo=try&revision=6f752abe1792d79811daf5e06423cd0394c640a5
Comment on attachment 8888084 [details] Bug 1382450: Turn on pref "dom.meta-viewport.enabled" for MathML reftest "font-inflation-1.html", like we do for other font-inflation reftests. https://reviewboard.mozilla.org/r/158984/#review164558
Attachment #8888084 - Flags: review?(jfkthame) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/056aa9b5ece3 Turn on pref "dom.meta-viewport.enabled" for MathML reftest "font-inflation-1.html", like we do for other font-inflation reftests. r=jfkthame
You need to log in before you can comment on or make changes to this bug.