Closed Bug 1382450 Opened 6 years ago Closed 6 years ago

enable pref "dom.meta-viewport.enabled" for MathML font-inflation-1.html reftest


(Core :: MathML, enhancement)

Not set



Tracking Status
firefox56 --- fixed


(Reporter: dholbert, Assigned: dholbert)




(1 file)

My initial landing of bug 1373767 triggered a test failure in layout/reftests/mathml/font-inflation-1.html, but only on Android.  The test passes reliably on other platforms, but that's just because it's not actually testing anything.

It turns out font inflation depends on whether <meta viewport> is enabled (and it's enabled by default on android, but not on other platforms).

For all other font inflation reftests, we seem to enable the "dom.meta-viewport.enabled" pref (so that they behave consistently across platforms). And if I make that change locally, then this test starts behaving like I'd expect (rendering text at larger sizes, and failing like it did on Android if I apply my patch from bug 1373767).

So let's add that pref annotation, for consistency & better platform-independent runnability of this test.
Note: here's where we set that pref (as a blanket enabling) for the other font inflation reftests:

...and we set it here for a font inflation + ruby reftest (along with some other prefs that don't seem to be necessary for this mathml case):
Try run (which shows some extra csets being pushed because it was based on inbound tip):
Blocks: 1373767
Comment on attachment 8888084 [details]
Bug 1382450: Turn on pref "dom.meta-viewport.enabled" for MathML reftest "font-inflation-1.html", like we do for other font-inflation reftests.
Attachment #8888084 - Flags: review?(jfkthame) → review+
Pushed by
Turn on pref "dom.meta-viewport.enabled" for MathML reftest "font-inflation-1.html", like we do for other font-inflation reftests. r=jfkthame
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.