1382517 - stylo: Add automation tests for 3D transform matrix decomposition

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P2)

Description

[Jeremy Chen ([e-mail])]

This is a followup of Bug 1381196. The lack of tests might bite us while doing animation/transition for 3D transforms. Per discussion w/ hiro, it might be better do add some tests to web-platform-tests, so other browsers can get the benefits as well.

Comment 1

[Jeremy Chen ([e-mail])]

Attachment: Bug 1382517 - add wpt interpolation test for mismatched 3D transforms.

This test aims for forcing the two mismatched transforms to be decomposed into
matrix3d before interpolation. To do so, we need to:

1. make 'From' and 'To' to be two mismatched transforms,
2. at least one of the two transforms has to be a 3D transform.

In this way, we not only test the interpolation, but also test the correctness
of 3D matrix decomposition.

Review commit: https://reviewboard.mozilla.org/r/159158/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/159158/

Comment 2

[Jeremy Chen ([e-mail])]

Comment on attachment 8888207 [details]
Bug 1382517 - add wpt interpolation test for mismatched 3D transforms.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/159158/diff/1-2/

Comment 3

[Jeremy Chen ([e-mail])]

This test can't pass on the latest m-c with stylo, but can pass on the latest autoland with stylo (since the fix in Bug 1381196 has been merged to autoland already). I verified this on my local, and will push to try to see how it goes.

Comment 4

[Jeremy Chen ([e-mail])]

Attachment: Bug 1382517 - update wpt manifest.

This is generated by running '--manifest-update' script.

I suspect that all the unrelated changes are generated because some authors
did not use the script to udpate the manifest. With this patch, we should
be able to make the manifest.json up-to-date.

Review commit: https://reviewboard.mozilla.org/r/159164/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/159164/

Comment 5

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8888217 [details]
Bug 1382517 - update wpt manifest.

https://reviewboard.mozilla.org/r/159164/#review164546

Comment 6

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8888207 [details]
Bug 1382517 - add wpt interpolation test for mismatched 3D transforms.

https://reviewboard.mozilla.org/r/159158/#review164548

This test case is pretty nice, easy to understand. Thanks!
But, if I recall correctly, there is a spec issue raised somewhere. The spec issue avoids muliplication of transform list. So, I'd suggest to use matrix3d() instead of 'scale(0.5) translateZ(1px)' and leave a comment about what the matrix3d is.

Comment 7

[Jeremy Chen ([e-mail])]

Comment on attachment 8888207 [details]
Bug 1382517 - add wpt interpolation test for mismatched 3D transforms.

https://reviewboard.mozilla.org/r/159158/#review164548

Ok, I'll use matrix3d() instead of 'scale(0.5) translateZ(1px)'.
Thank you for the review.

Comment 8

[Jeremy Chen ([e-mail])]

Comment on attachment 8888207 [details]
Bug 1382517 - add wpt interpolation test for mismatched 3D transforms.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/159158/diff/2-3/

Comment 9

[Jeremy Chen ([e-mail])]

Comment on attachment 8888217 [details]
Bug 1382517 - update wpt manifest.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/159164/diff/1-2/

Comment 10

[Jeremy Chen ([e-mail])]

try w/o the fix in Bug 1381196: https://treeherder.mozilla.org/#/jobs?repo=try&revision=06f8cc939de6b19ad0a9c6ca39951391fb62017a
try w/ the fix: https://treeherder.mozilla.org/#/jobs?repo=try&revision=19ee5b6e0bfe75aec8ae12a00569f0648d1297fb

Looks good.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/083ab3447c4c
add wpt interpolation test for mismatched 3D transforms. r=hiro
https://hg.mozilla.org/integration/autoland/rev/6d52fa995459
update wpt manifest. r=hiro

Comment 12

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/083ab3447c4c
https://hg.mozilla.org/mozilla-central/rev/6d52fa995459