stylo: Add automation tests for 3D transform matrix decomposition

RESOLVED FIXED in Firefox 56

Status

()

enhancement
P2
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jeremychen, Assigned: jeremychen)

Tracking

unspecified
mozilla56
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox56 fixed)

Details

Attachments

(2 attachments)

This is a followup of Bug 1381196. The lack of tests might bite us while doing animation/transition for 3D transforms. Per discussion w/ hiro, it might be better do add some tests to web-platform-tests, so other browsers can get the benefits as well.
This test can't pass on the latest m-c with stylo, but can pass on the latest autoland with stylo (since the fix in Bug 1381196 has been merged to autoland already). I verified this on my local, and will push to try to see how it goes.
Attachment #8888207 - Flags: review?(hikezoe)
Attachment #8888217 - Flags: review?(hikezoe)
Comment on attachment 8888217 [details]
Bug 1382517 - update wpt manifest.

https://reviewboard.mozilla.org/r/159164/#review164546
Attachment #8888217 - Flags: review?(hikezoe) → review+
Comment on attachment 8888207 [details]
Bug 1382517 - add wpt interpolation test for mismatched 3D transforms.

https://reviewboard.mozilla.org/r/159158/#review164548

This test case is pretty nice, easy to understand. Thanks!
But, if I recall correctly, there is a spec issue raised somewhere. The spec issue avoids muliplication of transform list. So, I'd suggest to use matrix3d() instead of 'scale(0.5) translateZ(1px)' and leave a comment about what the matrix3d is.
Attachment #8888207 - Flags: review?(hikezoe) → review+
Comment on attachment 8888207 [details]
Bug 1382517 - add wpt interpolation test for mismatched 3D transforms.

https://reviewboard.mozilla.org/r/159158/#review164548

Ok, I'll use matrix3d() instead of 'scale(0.5) translateZ(1px)'.
Thank you for the review.
Pushed by jichen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/083ab3447c4c
add wpt interpolation test for mismatched 3D transforms. r=hiro
https://hg.mozilla.org/integration/autoland/rev/6d52fa995459
update wpt manifest. r=hiro
https://hg.mozilla.org/mozilla-central/rev/083ab3447c4c
https://hg.mozilla.org/mozilla-central/rev/6d52fa995459
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.