1382525 - Move LLVM_CONFIG out of mozconfig.common

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Comment 1

[Mike Hommey [:glandium] (PTO. Back on Nov 25)]

Attachment: Bug 1382525 - Move LLVM_CONFIG out of mozconfig.common.

LLVM_CONFIG, per the contents of toolkit/moz.configure, is tied to
--enable-stylo, but it currently is set on all types of builds. It
currently happens to work, but it's actually not meant to, and sure
enough, the fix for bug 1374727 exacerbates that.

So we create a new mozconfig.stylo file that enables stylo and sets
LLVM_CONFIG, such that only build types that do enable stylo have
LLVM_CONFIG set.

Review commit: https://reviewboard.mozilla.org/r/159078/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/159078/

Comment 2

[Mike Hommey [:glandium] (PTO. Back on Nov 25)]

Comment on attachment 8888167 [details]
Bug 1382525 - Move LLVM_CONFIG out of mozconfig.common.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/159078/diff/1-2/

Comment 3

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8888167 [details]
Bug 1382525 - Move LLVM_CONFIG out of mozconfig.common.

https://reviewboard.mozilla.org/r/159078/#review164780

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7430f157b160
Move LLVM_CONFIG out of mozconfig.common. r=chmanchester

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7b16c219d018
Followup to update a few more mozconfigs a=bustage

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7430f157b160
https://hg.mozilla.org/mozilla-central/rev/7b16c219d018

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/3c92ef2830ac
Keep build files in sync (Port bug 1382525: Move LLVM_CONFIG out of mozconfig.common). rs=bustage-fix