Closed Bug 1382556 Opened 3 years ago Closed 3 years ago
Verify that histogram
_tools .py breaks compilation if "bug _numbers" is missing from new histograms
That did not seem to happen in bug 1356812, when a new histogram was added with no bug_numbers field.
Assignee: nobody → alessio.placitelli
Priority: -- → P1
Looks like that, even if the whitelist file is loaded, it is never used. This seems to be a regression from bug 1365577.
Hey Chris, this patch marks the "whitelists" variable as global within |load_whitelists()|, otherwise the data won't be available from outside the function. It also fixes the histogram that landed while this was broken.
Attachment #8888215 - Flags: review?(chutten)
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/4ff87819abe8 Fix loading the whitelist file from histogram_tools.py. r=chutten
You need to log in before you can comment on or make changes to this bug.