Closed
Bug 1382556
Opened 9 years ago
Closed 8 years ago
Verify that histogram_tools.py breaks compilation if "bug_numbers" is missing from new histograms
Categories
(Toolkit :: Telemetry, defect, P1)
Toolkit
Telemetry
Tracking
()
RESOLVED
FIXED
mozilla56
| Tracking | Status | |
|---|---|---|
| firefox-esr52 | --- | unaffected |
| firefox54 | --- | unaffected |
| firefox55 | --- | wontfix |
| firefox56 | --- | fixed |
People
(Reporter: Dexter, Assigned: Dexter)
References
Details
(Whiteboard: [measurement:client])
Attachments
(1 file)
|
8.49 KB,
patch
|
chutten
:
review+
|
Details | Diff | Splinter Review |
That did not seem to happen in bug 1356812, when a new histogram was added with no bug_numbers field.
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → alessio.placitelli
Priority: -- → P1
Whiteboard: [measurement:client]
|
|
Assignee | |
Comment 1•9 years ago
|
||
Looks like that, even if the whitelist file is loaded, it is never used. This seems to be a regression from bug 1365577.
Blocks: 1365577
|
|
Assignee | |
Comment 2•9 years ago
|
||
Hey Chris, this patch marks the "whitelists" variable as global within |load_whitelists()|, otherwise the data won't be available from outside the function.
It also fixes the histogram that landed while this was broken.
Attachment #8888215 -
Flags: review?(chutten)
|
||
Updated•9 years ago
|
status-firefox54:
--- → unaffected
status-firefox55:
--- → affected
status-firefox56:
--- → affected
status-firefox-esr52:
--- → unaffected
|
|
Assignee | |
Comment 3•9 years ago
|
||
|
||
Updated•9 years ago
|
Attachment #8888215 -
Flags: review?(chutten) → review+
Pushed by alessio.placitelli@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4ff87819abe8
Fix loading the whitelist file from histogram_tools.py. r=chutten
|
||
Comment 5•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
|
|
||
Updated•8 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•