Closed Bug 1382561 Opened 2 years ago Closed 2 years ago

Sync does not start after email confirmation

Categories

(Firefox for iOS :: Sync, defect, P1)

All
iOS
defect

Tracking

()

RESOLVED FIXED
Iteration:
1.30
Tracking Status
fxios 9.1 ---
fxios-v8.0 --- affected
fxios-v9.0 --- affected
fxios-v10.0 --- verified

People

(Reporter: SimonB, Assigned: jhugman)

References

Details

(Keywords: regression, Whiteboard: [MobileCore][Sync])

Attachments

(1 file)

Build: e14617f7e3
Device: iPad Air 2  
iOS: 10.3.3

Steps to reproduce:
1. Sign in to FxA on iOS Device
2. Go to inbox and confirm the sign in 

Actual results: 
- After confirming the sing in, sync does not start automatically.

Expected result: 
- Sync should be triggered after confirming the sing in.
Keywords: regression
Whiteboard: [MobileCore][Sync]
From Bug 1376007, commment 3:
> Last week worked with James and this is what we found/updated:
> 
>  * Deployed a new version of http://ios-push2.dev.lcip.org, that always sends an `accountVerify` message.
>  * Changed `case accountVerified = "accountVerify"`, line 224 in FxAPushMessageHandler
> 
> Tested with an updated PyFxA script to simulate sending the message
> 
> ```
> from getpass import getpass
> from fxa.core import Client
> 
> c = Client("https://ios-push2.dev.lcip.org/auth/v1")
> s = c.login(email, password)
> 
> try:
>     s.apiclient.post("/account/devices/notify", json={
>       "to": "all",
>       "endpointAction": "accountVerify",
>       "payload": {}
>     }, auth=s._auth)
> finally:
>     s.destroy_session()
> ```
> 
> I noticed that if the account is unverified, the push messaged received is nil. Manually verifying the account and re-running script correctly shows an `accountVerify` push message. Is it possible that there is something in the iOS client that doesn't correctly register push messaging until after an account has been confirmed?
Assignee: nobody → jhugman
See Also: → 1395547
Iteration: --- → 1.30
Priority: -- → P1
Status: NEW → ASSIGNED
Attachment #8908264 - Flags: review?(jdarcangelo) → review?(rnewman)
Comment on attachment 8908264 [details] [review]
Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/3177

Removing from st3fan 's reviews.
Attachment #8908264 - Flags: review?(sarentz)
Attachment #8908264 - Flags: review?(rnewman) → review?(jdarcangelo)
Attachment #8908264 - Flags: review?(jdarcangelo) → review+
Merged into master.
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Whiteboard: [MobileCore][Sync] → [MobileCore][Sync][NeedsUplift]
Depends on: 1403958
Verifying as fix on master a9b288f1c85a.
Uplifted to v10.x
Whiteboard: [MobileCore][Sync][NeedsUplift] → [MobileCore][Sync]
You need to log in before you can comment on or make changes to this bug.