1382561 - Sync does not start after email confirmation

Status: RESOLVED FIXED

(Firefox for iOS :: Sync, defect, P1)

Description

[Simon Basca [:SimonB]]

Build: e14617f7e3
Device: iPad Air 2  
iOS: 10.3.3

Steps to reproduce:
1. Sign in to FxA on iOS Device
2. Go to inbox and confirm the sign in 

Actual results: 
- After confirming the sing in, sync does not start automatically.

Expected result: 
- Sync should be triggered after confirming the sing in.

Comment 1

[James Hugman [:jhugman] [@jhugman]]

From Bug 1376007, commment 3:
> Last week worked with James and this is what we found/updated:
> 
>  * Deployed a new version of http://ios-push2.dev.lcip.org, that always sends an `accountVerify` message.
>  * Changed `case accountVerified = "accountVerify"`, line 224 in FxAPushMessageHandler
> 
> Tested with an updated PyFxA script to simulate sending the message
> 
> ```
> from getpass import getpass
> from fxa.core import Client
> 
> c = Client("https://ios-push2.dev.lcip.org/auth/v1")
> s = c.login(email, password)
> 
> try:
>     s.apiclient.post("/account/devices/notify", json={
>       "to": "all",
>       "endpointAction": "accountVerify",
>       "payload": {}
>     }, auth=s._auth)
> finally:
>     s.destroy_session()
> ```
> 
> I noticed that if the account is unverified, the push messaged received is nil. Manually verifying the account and re-running script correctly shows an `accountVerify` push message. Is it possible that there is something in the iOS client that doesn't correctly register push messaging until after an account has been confirmed?

Comment 2

[James Hugman [:jhugman] [@jhugman]]

Attachment: Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/3177

Comment 3

[James Hugman [:jhugman] [@jhugman]]

Comment on attachment 8908264 [details] [review]
Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/3177

Removing from st3fan 's reviews.

Comment 4

[James Hugman [:jhugman] [@jhugman]]

Merged into master.

Comment 5

[Simon Basca [:SimonB]]

Verifying as fix on master a9b288f1c85a.

Comment 6

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Uplifted to v10.x