1382599 - Fix 19 tests failures on devtools/client/inspector/rules due the EventEmitter refactoring

Status: RESOLVED FIXED

(DevTools :: Inspector: Rules, enhancement, P2)

Description

[Matteo Ferretti [:zer0] [:matteo]]

Failing tests:

devtools/client/inspector/rules/test/browser_rules_add-property-and-reselect.js
devtools/client/inspector/rules/test/browser_rules_add-property-cancel_01.js
devtools/client/inspector/rules/test/browser_rules_add-property-cancel_02.js
devtools/client/inspector/rules/test/browser_rules_add-property-cancel_03.js
devtools/client/inspector/rules/test/browser_rules_add-property-commented.js
devtools/client/inspector/rules/test/browser_rules_add-property-svg.js
devtools/client/inspector/rules/test/browser_rules_add-property_01.js
devtools/client/inspector/rules/test/browser_rules_add-property_02.js
devtools/client/inspector/rules/test/browser_rules_add-rule-and-property.js
devtools/client/inspector/rules/test/browser_rules_add-rule-button-state.js
devtools/client/inspector/rules/test/browser_rules_add-rule-edit-selector.js
devtools/client/inspector/rules/test/browser_rules_add-rule-iframes.js
devtools/client/inspector/rules/test/browser_rules_add-rule-namespace-elements.js
devtools/client/inspector/rules/test/browser_rules_add-rule-pseudo-class.js
devtools/client/inspector/rules/test/browser_rules_add-rule-then-property-edit-selector.js
devtools/client/inspector/rules/test/browser_rules_add-rule-with-menu.js
devtools/client/inspector/rules/test/browser_rules_add-rule.js
devtools/client/inspector/rules/test/browser_rules_copy_styles.js
devtools/client/inspector/rules/test/browser_rules_select-and-copy-styles.js


The refactoring is currently only on:

https://github.com/zer0/gecko/tree/event-emitter-1381542

We need to address the test failures before land this patch in m-c.

Comment 1

[Matteo Ferretti [:zer0] [:matteo]]

Here the original try build with the failures:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=bba13e27a2371fa8aad68b9b227534b31829cb0d

Those failures are most likely due the breaking change in how the `EventEmitter` emits event.

Previously, the first argument was the type event:

  myEmitter.on("custom-event", (eventType, message) => { ... });

Now the first argument is the message:

  myEmitter.on("custom-event", (message) => { ... });

In the majority of the scenario the `eventType` is ignored by our code, so we should just remove it from the function's signature.

For more details, see: https://github.com/devtools-html/snippets-for-removing-the-sdk/#events

Comment 2

[Yulia Startsev [:yulia]]

Attachment: Bug 1382599 - update inspector/rules to the new event emitter.

Review commit: https://reviewboard.mozilla.org/r/228028/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/228028/

Comment 3

[Patrick Brosset <:pbro>]

Comment on attachment 8959161 [details]
Bug 1382599 - update inspector/rules to the new event emitter.

https://reviewboard.mozilla.org/r/228028/#review233906

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4a55a695dc75
update inspector/rules to the new event emitter. r=pbro

Comment 5

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/4a55a695dc75