1382635 - FormDataListener shouldn't listen for change events

Status: RESOLVED FIXED

(Firefox :: Session Restore, enhancement)

Description

[Tim Taubert [:ttaubert] (inactive)]

As already mentioned by Ehsan in bug 1373672 comment #0, the FormDataListener listens for both change and input events, based on a decision made long before we imported the add-on code into Firefox.

AFAICT whenever the user interacts with a form element we dispatch the "input" event properly, I couldn't find a counterexample. In the past (Firefox 2 and before) we might have had inconsistent behavior.

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Attachment: 0002-Bug-1382635-FormDataListener-shouldn-t-listen-for-ch.patch

I removed browser_form_restore_events_sample.html completely because that actually doesn't really seem to test anything. We send fake events from the content script and those are of course exactly the ones we expect.

Comment 2

[Mike de Boer [:mikedeboer]]

Comment on attachment 8888268 [details] [diff] [review]
0002-Bug-1382635-FormDataListener-shouldn-t-listen-for-ch.patch

Review of attachment 8888268 [details] [diff] [review]:
-----------------------------------------------------------------

I'm intrigued...very curious to see what the impact will be on various benchmarks, because I think the 'change' event is mostly fired when 'tabbing' out of a form control, which will now no longer fire a collect() and therefore reduce possible jank in the most important phase: form field navigation.
Thanks for this change!

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d00bbfd7ac832ae1fe75b779d2a18d455cc66798

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d1340f39e016
FormDataListener shouldn't listen for change events r=mikedeboer

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d1340f39e016