1382642 - With "extensions.legacy.enabled" pref active legacy add-ons can be installed from Add-ons Manager - Search results page

Status: RESOLVED WONTFIX

(Toolkit :: Add-ons Manager, defect)

Description

[Valentina Virlics [:vvalentina], VPN QA]

Attachment: video.gif

[Affected versions]: 
Nightly 56.0a1 (2017-07-19) (64-bit)
Firefox 55.0b10 (20170717063821)

[Affected platforms]:
Windows 7 64-bit
Ubuntu 16.04 32-bit

[Prerequisites]:
- set extensions.legacy.enabled to "false"

[Steps to reproduce]:
1. Load about:addons
2. Search for a legacy add-on using search field from Extensions/Appearance tab
3. Install a legacy add-on i.e. "iMacros for Firefox"

[Expected results]:
Add-on cannot be installed because is not compatible with Nightly 56.0a1. Add-on is not listed anywhere in about:addons pages.

[Actual results]:
Add-on is installed and automatically disabled. Add-on is listed in Legacy Extensions tab.

[Additional notes]:
1. "Legacy Extensions" tab has no name while being accessed from Extensions tab - "Show legacy extensions" link - Tab name appears after page refresh
2. Installing the add-on from AMO (https://addons.mozilla.org/en-US/firefox/addon/imacros-for-firefox/?src=search), via drag&drop or using "Install from file" is not possible;
3. Creating the Disco Pane "mamo" cookie (extensions.webapi.testing : true) will also make add-ons install possible from new AMO desktop pages;

Comment 1

[Andrew Swan [:aswan]]

We already send the browser version to AMO for searches from about:addons.  I *think* it is the case that the search api does not return results that are not compatible with the running version.  And I also think it is the case that AMO will treat legacy extensions as having a max version of 56.*  Which means that if we haven't managed to kill about:addons search by the time 57 comes around, this won't be a problem there, since legacy extensions simply won't be presented in search results.
Since the extensions.legacy.enabled preference exists mostly for testing prior to 57, I'm inclined to WONTFIX this if the above statements about AMO are true.  Stuart, did I get the above correct?

Comment 2

[Stuart Colville [:muffinresearch]]

(In reply to Andrew Swan [:aswan] from comment #1)
> We already send the browser version to AMO for searches from about:addons. 
> I *think* it is the case that the search api does not return results that
> are not compatible with the running version.  And I also think it is the
> case that AMO will treat legacy extensions as having a max version of 56.* 
> Which means that if we haven't managed to kill about:addons search by the
> time 57 comes around, this won't be a problem there, since legacy extensions
> simply won't be presented in search results.
> Since the extensions.legacy.enabled preference exists mostly for testing
> prior to 57, I'm inclined to WONTFIX this if the above statements about AMO
> are true.  Stuart, did I get the above correct?

Yep that sounds right - the current work to handle that compatibility change is here: https://github.com/mozilla/addons-server/issues/5277

Comment 3

[Andrew Swan [:aswan]]

Closing based on comment 1 and comment 2