1382690 - Adapt extensions inspect() calls to the new console frontend

Status: RESOLVED FIXED

(DevTools :: Console, enhancement, P1)

Description

[Nicolas Chevobbe [:nchevobbe]]

In Bug 1379570 we changed how the inspect command works in the new console frontend.
Unfortunately this change does not catch inspect calls from extension.

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1382690 - Adapt extensions inspect() calls to the new frontend.

The inspect command in extension was directly calling jsterm.inspectObject and doing so bypassed
the code we implemented for the command on the new frontend (i.e. no more variable view).
This patch modifies the jsterm inspectObject function so it can do the expected behavior,
and also reverts some changes made in the original inspect command bug, so we only deal with
the new frontend code in jsterm.inspectObject.
This implied changing an extension test that was waiting for the variable view to boot-up.
The test was modified to match the tests we already have for the inspect command on the new
console frontend.

Review commit: https://reviewboard.mozilla.org/r/159294/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/159294/

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8888349 [details]
Bug 1382690 - Adapt extensions inspect() calls to the new frontend.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/159294/diff/1-2/

Comment 3

[Brian Grinstead [:bgrins]]

Comment on attachment 8888349 [details]
Bug 1382690 - Adapt extensions inspect() calls to the new frontend.

https://reviewboard.mozilla.org/r/159294/#review164668

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8888349 [details]
Bug 1382690 - Adapt extensions inspect() calls to the new frontend.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/159294/diff/2-3/

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

TRY is green https://treeherder.mozilla.org/#/jobs?repo=try&revision=72f01e34cad4fb771e83e564a0714cd3e864cddc

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5b783cc7bb39
Adapt extensions inspect() calls to the new frontend. r=bgrins

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/5b783cc7bb39