1382713 - stylo: Benchmark Servo_DeclarationBlock_SetPropertyById with both "10px" and " 10px"

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Comment 1

[Simon Sapin (:SimonSapin)]

Attachment: Bug 1382713 - Bench stylo setProperty with both "10px" and " 10px".

Review commit: https://reviewboard.mozilla.org/r/159306/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/159306/

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Comment on attachment 8888360 [details]
Bug 1382713 - Bench stylo setProperty with both "10px" and " 10px".

https://reviewboard.mozilla.org/r/159306/#review164724

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5ead239873ba
Bench stylo setProperty with both "10px" and " 10px". r=emilio

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/5ead239873ba

Comment 5

[Ionuț Goldan [:igoldan]]

This caused a new baseline for the micro tests:

== Change summary for alert #8119 (as of July 20 2017 16:28 UTC) ==

Improvements:

 16%  Stylo Servo_DeclarationBlock_SetPropertyById_Bench windows7-32-vm opt      807,764.25 -> 675,970.33
 14%  Stylo Servo_DeclarationBlock_SetPropertyById_Bench osx-10-10 opt           662,586.38 -> 571,899.58
 12%  Stylo Servo_DeclarationBlock_SetPropertyById_Bench windows8-64 opt         679,961.92 -> 599,220.67

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=8119

Comment 6

[Simon Sapin (:SimonSapin)]

FWIW this is not a "real" improvement: this patch only changed what was measured with that benchmark name, and added a separate benchmark with a different name with the previous behavior.