Closed Bug 1382724 Opened 7 years ago Closed 7 years ago

Bug 1367081 broke dropdowns on Fennec in some cases.

Categories

(Firefox for Android Graveyard :: General, defect)

defect
Not set
normal

Tracking

(fennec+, firefox54 unaffected, firefox55+ fixed, firefox56 fixed)

RESOLVED FIXED
Firefox 56
Tracking Status
fennec + ---
firefox54 --- unaffected
firefox55 + fixed
firefox56 --- fixed

People

(Reporter: wisniewskit, Assigned: jchen)

References

()

Details

(Keywords: regression, Whiteboard: [webcompat])

Attachments

(1 file)

It looks like something in bug 1367081 broke the page select drop-down in the hamburger menu at https://hitomi.la/reader/1086231.html#4 (warning! potentially NSFW!)

Mozregression gave me this range: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=9745b4fb9ac4f6af7f66d8211eb4a061939ecc36&tochange=44c1b092e6ce7386b009c34787c45ed0901c2867
tracking-fennec: --- → ?
Flags: webcompat?
Hi James, would you help check if this is from bug 1367081? Thanks.
Flags: needinfo?(snorp)
-> jchen
Flags: needinfo?(snorp) → needinfo?(nchen)
Assignee: nobody → nchen
Status: NEW → ASSIGNED
Flags: needinfo?(nchen)
Blocks: 1367081
No longer depends on: 1367081
Keywords: regression
Capture click events for select and input elements to restore previous
behavior. This will always invoke helper prompts for those elements,
even if scripts stop the click event propagation. r=me for trivial
patch.
Attachment #8892199 - Flags: review+
Pushed by nchen@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1b8336b8d1df
Capture select and input click events; r=me
https://hg.mozilla.org/mozilla-central/rev/1b8336b8d1df
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
AFAICT, the regressing commit landed on Fx55. Is this something we'd consider for a dot release ride-along should the opportunity arise? We're already creating RC builds for 55, so I think it's too late for next week's release.
Flags: needinfo?(nchen)
tracking-fennec: ? → +
Yeah this regression affects a lot of sites that use bootstrap dropdowns. I think it's a bug in bootstrap but we need this for webcompat.
Flags: needinfo?(nchen)
Comment on attachment 8892199 [details] [diff] [review]
Capture select and input click events (v1)

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1367081
[User impact if declined]: Select dropdowns don't work for certain sites (e.g. some sites that use Bootstrap)
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: No
[Is the change risky?]: No
[Why is the change risky/not risky?]: It's only a small change to restore previous behavior
[String changes made/needed]: None
Attachment #8892199 - Flags: approval-mozilla-release?
Attachment #8892199 - Flags: approval-mozilla-beta?
Comment on attachment 8892199 [details] [diff] [review]
Capture select and input click events (v1)

56 is already on Beta.
Attachment #8892199 - Flags: approval-mozilla-beta?
Comment on attachment 8892199 [details] [diff] [review]
Capture select and input click events (v1)

A bit late but let's take in 55.0 rc 3
Attachment #8892199 - Flags: approval-mozilla-release? → approval-mozilla-release+
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.