1382724 - Bug 1367081 broke dropdowns on Fennec in some cases.

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Thomas Wisniewski]

It looks like something in bug 1367081 broke the page select drop-down in the hamburger menu at https://hitomi.la/reader/1086231.html#4 (warning! potentially NSFW!)

Mozregression gave me this range: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=9745b4fb9ac4f6af7f66d8211eb4a061939ecc36&tochange=44c1b092e6ce7386b009c34787c45ed0901c2867

Comment 1

[Wesly Huang (EPM)]

Hi James, would you help check if this is from bug 1367081? Thanks.

Comment 2

[James Willcox (:snorp) ([e-mail]) (he/him)]

-> jchen

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Capture select and input click events (v1)

Capture click events for select and input elements to restore previous
behavior. This will always invoke helper prompts for those elements,
even if scripts stop the click event propagation. r=me for trivial
patch.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1b8336b8d1df
Capture select and input click events; r=me

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/1b8336b8d1df

Comment 6

[Ryan VanderMeulen [:RyanVM]]

AFAICT, the regressing commit landed on Fx55. Is this something we'd consider for a dot release ride-along should the opportunity arise? We're already creating RC builds for 55, so I think it's too late for next week's release.

Comment 7

[(inactive) Jim Chen [:jchen] [:darchons]]

Yeah this regression affects a lot of sites that use bootstrap dropdowns. I think it's a bug in bootstrap but we need this for webcompat.

Comment 8

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8892199 [details] [diff] [review]
Capture select and input click events (v1)

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1367081
[User impact if declined]: Select dropdowns don't work for certain sites (e.g. some sites that use Bootstrap)
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: No
[Is the change risky?]: No
[Why is the change risky/not risky?]: It's only a small change to restore previous behavior
[String changes made/needed]: None

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8892199 [details] [diff] [review]
Capture select and input click events (v1)

56 is already on Beta.

Comment 10

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8892199 [details] [diff] [review]
Capture select and input click events (v1)

A bit late but let's take in 55.0 rc 3

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/cfaefaaafa4d