Closed Bug 1382746 Opened 3 years ago Closed 3 years ago

Provide a helper function to remove the preloaded browser

Categories

(Firefox :: General, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
Firefox 56
Tracking Status
firefox56 --- fixed

People

(Reporter: Mardak, Assigned: k88hudson)

References

Details

Attachments

(1 file)

This will be used by awsy when measuring tabs closed as the new baseline with bug 1381804.

This logic already exists from bug 1373271.
Summary: Provide a helper function to remove the preallocated browser → Provide a helper function to remove the preloaded browser
erahm, can you file the bug/issue to depend on this bug so awsy test can be updated to call the method that will be implemented here?
Attachment #8888441 - Flags: review?(edilee)
Comment on attachment 8888441 [details]
Bug 1382746 - Provide a helper function to remove the preloaded browser

https://reviewboard.mozilla.org/r/159394/#review164766

Do we not want to refactor `oop-browser-crashed` to call this method?

::: browser/base/content/tabbrowser.xml:1987
(Diff revision 1)
>  
> +      <method name="removePreloadedBrowser">
> +        <body>
> +          <![CDATA[
> +            if (!this._isPreloadingEnabled()) {
> +              return null;

Just a `return;` with no `null` as success returns nothing/`undefined` anyway.
Attachment #8888441 - Flags: review?(edilee)
Comment on attachment 8888441 [details]
Bug 1382746 - Provide a helper function to remove the preloaded browser

https://reviewboard.mozilla.org/r/159394/#review164878
Attachment #8888441 - Flags: review?(edilee) → review+
Pushed by edilee@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/e357672c1dd1
Provide a helper function to remove the preloaded browser r=Mardak
Blocks: 1382889
https://hg.mozilla.org/mozilla-central/rev/e357672c1dd1
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
Assignee: nobody → khudson
You need to log in before you can comment on or make changes to this bug.