Closed
Bug 1382852
Opened 7 years ago
Closed 7 years ago
Wrong value is reported for NETWORK_RACE_CACHE_WITH_NETWORK_USAGE_2 probe when cache wins in delayed race
Categories
(Core :: Networking: Cache, enhancement)
Core
Networking: Cache
Tracking
()
RESOLVED
FIXED
mozilla56
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: michal, Assigned: michal)
References
Details
(Whiteboard: [necko-active])
Attachments
(1 file)
|
1.44 KB,
patch
|
valentin
:
review+
|
Details | Diff | Splinter Review |
http://searchfox.org/mozilla-central/rev/3a3af33f513071ea829debdfbc628caebcdf6996/netwerk/protocol/http/nsHttpChannel.cpp#9083 reports CacheDelayedRace only in case the network was already triggered. In majority cases the cache will win the delayed race before hitting the network and CacheNoRace will be reported, which is obviously not what we want.
|
Assignee | |
Comment 1•7 years ago
|
||
Attachment #8888542 -
Flags: review?(valentin.gosu)
|
||
Updated•7 years ago
|
Attachment #8888542 -
Flags: review?(valentin.gosu) → review+
Pushed by mnovotny@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/ca6ed7d3d711 Wrong value is reported for NETWORK_RACE_CACHE_WITH_NETWORK_USAGE_2 probe when cache wins in delayed race, r=valentin
|
||
Comment 3•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/ca6ed7d3d711
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•