1382952 - Legacy Extensions tab icon is not deleted after inactivating the legacy pref

Status: RESOLVED WONTFIX

(Toolkit :: Add-ons Manager, defect)

Description

[Valentina Virlics [:vvalentina], Ecosystem QA]

Attachment: LegacyExtensions.zip

[Affected versions]: 
Nightly 56.0a1 (2017-07-20) (64-bit)

[Affected platforms]:
Windows 7 64-bit
Mac OS X 10.11

set extensions.legacy.enabled to "false"

[Steps to reproduce]:
1. Install a legacy add-on i.e. https://addons.mozilla.org/en-US/firefox/addon/vimfx/?src=hp-dl-featured
2. Set extensions.legacy.enabled to "false" and restart browser
3. Go to about:addons and access Legacy Extensions tab 
3. Go to about:config and set extensions.legacy.enabled to "true"
4. Restart the browser while in Legacy Extensions tab

[Expected results]:
The legacy add-on is moved from Legacy Extensions tab to Extensions tab.
The Legacy Extensions Tab is removed.

[Actual results]:
The Legacy Extensions tab icon is not removed. Nothing happens if clicked.

[Additional notes]:
- refreshing the page will remove the icon 
- if user is in Legacy Extensions Tab before step 4, a hybrid form the legacy add-on is displayed.

Comment 1

[Andrew Swan [:aswan]]

Its true that the transition from "legacy extensions disabled" to "legacy extensions allowed" is not handled smoothly in the scenario described here, but that's a transition that's only going to happen during testing so not one we're going to put any work into improving...

Comment 2

[krupa raj [:krupa--use this to needinfo]]

(In reply to Andrew Swan [:aswan] from comment #1)
> Its true that the transition from "legacy extensions disabled" to "legacy
> extensions allowed" is not handled smoothly in the scenario described here,
> but that's a transition that's only going to happen during testing so not
> one we're going to put any work into improving...

I think Nightly users who want to use legacy extensions will also see this issue. Like previously discussed, we should at least indicate to the user that they need to restart the browser.

NI'ing UX for recommendations.

Comment 3

[emanuela [ux]]

Hey, I finally got to the test those 2 scenarios.

I agree with Krupa, it's not ideal and we're going to have some users try to do it. But, I don't think extra UI will help.

Possible solutions:

A) We force a way back to the Extensions tab.

B) We *don't* remove the legacy extensions tab and we lists all the Legacy Extensions there but enable (It was one of the first solution we had)

C) Somehow, don't know if possible, we need to force 2 re-loads of the page (it's not necessary to restart the browser)



aswan: what do you think?