Closed
Bug 1383058
Opened 7 years ago
Closed 7 years ago
[Form Autofill] Always adopt autocomplete attribute and the info should not be changed.
Categories
(Toolkit :: Form Manager, defect, P1)
Toolkit
Form Manager
Tracking
()
RESOLVED
FIXED
mozilla57
People
(Reporter: selee, Assigned: selee)
References
(Blocks 1 open bug)
Details
(Whiteboard: [form autofill:M4] )
Attachments
(1 file)
The info from autocomplete attribute should not be modified by any codes e.g. _parsePhoneFields and _parseAddressFields.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8888801 [details] Bug 1383058 - Always adopt the info from autocomplete attribute. https://reviewboard.mozilla.org/r/159838/#review174210 ::: browser/extensions/formautofill/FormAutofillHandler.jsm:117 (Diff revision 3) > * Set fieldDetails from the form about fields that can be autofilled. > > * @returns {Array} The valid address and credit card details. > */ > - collectFormFields() { > + collectFormFields(allowDuplicates = false) { Please document this argument in the comment ::: browser/extensions/formautofill/FormAutofillHeuristics.jsm:295 (Diff revision 3) > - getFormInfo(form) { > + getFormInfo(form, allowDuplicates = false) { > if (form.autocomplete == "off" || form.elements.length <= 0) { Please document this method with jsdoc ::: browser/extensions/formautofill/test/fixtures/telephone_fields.html:5 (Diff revision 3) > + <title>Form Autofill Demo Page</title> > +</head> > +<body> > + <h1>Form Autofill Demo Page</h1> Please provide a more descriptive title+h1 ::: browser/extensions/formautofill/test/fixtures/telephone_fields.html:10 (Diff revision 3) > + <p><label>organization: <input type="text" id="organization" name="organization" autocomplete="organization" /></label></p> > + <p><label>streetAddress: <input type="text" id="street-address" name="street-address" autocomplete="street-address" /></label></p> > + <p><label>addressLevel2: <input type="text" id="address-level2" name="address-level2" autocomplete="address-level2" /></label></p> Please remove any unnecessary attributes e.g. type="text"
Attachment #8888801 -
Flags: review?(MattN+bmo) → review+
Comment hidden (mozreview-request) |
Assignee | ||
Comment 6•7 years ago
|
||
In the previous version, these two files are the leftover when testing the patch. I removed them in the latest version. browser/extensions/formautofill/test/fixtures/telephone_fields.html browser/extensions/formautofill/test/unit/heuristics/test_telephone.js Sorry for the confusion.
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/autoland/rev/a315cc6a25bb Always adopt the info from autocomplete attribute. r=MattN
Keywords: checkin-needed
Comment 8•7 years ago
|
||
Backed out for eslint failure at browser/extensions/formautofill/FormAutofillHeuristics.jsm:329:12 | Unnecessary 'else' after 'return': https://hg.mozilla.org/integration/autoland/rev/632a4aed2e2cdd273dfcf1b0d9a7572507555077 Push with failure: browser/extensions/formautofill/FormAutofillHeuristics.jsm:329:12 | Unnecessary 'else' after 'return'. Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=123549721&repo=autoland > TEST-UNEXPECTED-ERROR | /home/worker/checkouts/gecko/browser/extensions/formautofill/FormAutofillHeuristics.jsm:329:12 | Unnecessary 'else' after 'return'. (no-else-return)
Flags: needinfo?(selee)
Pushed by mozilla@noorenberghe.ca: https://hg.mozilla.org/integration/mozilla-inbound/rev/15514c755d21 Always adopt the info from the autocomplete attribute for autofill. r=MattN
Comment 10•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/15514c755d21
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Assignee | ||
Comment 11•7 years ago
|
||
Hey MattN, thanks for fixing the eslint issue!
Flags: needinfo?(selee)
Comment 12•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/f74b69ba1dab
status-firefox56:
--- → fixed
Flags: in-testsuite+
You need to log in
before you can comment on or make changes to this bug.
Description
•