1383100 - Replace cloneInto with StructuredCloneHolder in devtools/server/actors/webconsole/content-process-forward.js

Status: NEW

(DevTools :: General, enhancement)

Description

[Julien Wajsberg [:julienw]]

As discussed in bug 1380449 we should try to use StructuredCloneHolder instead of cloneInto so that we don't get the clone penalty in the calling thread.

Comment 1

[Julien Wajsberg [:julienw]]

Attachment: Bug 1383100 - Use StructuredCloneHolder instead of cloneInto to log objects because of performance regression for big objects.

Review commit: https://reviewboard.mozilla.org/r/159864/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/159864/

Comment 2

[Julien Wajsberg [:julienw]]

This patch seems to trigger crashes for console usages in Workers.

Comment 3

[Andy McKay]

Does this need a review, eg from :kmag?

Comment 4

[Julien Wajsberg [:julienw]]

Comment on attachment 8888838 [details]
Bug 1383100 - Use StructuredCloneHolder instead of cloneInto to log objects because of performance regression for big objects.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/159864/diff/1-2/

Comment 5

[Julien Wajsberg [:julienw]]

My previous try run [1] showed crashes on Windows and I didn't have the time to investigate this as I've been away for a week.

Also the patch in bug 1380449 fixes the bigger issue so this one is now IMO a nice to have, that's why I didn't want to invest much more time in it.

I just rebased, resolved conflicts, push to mozreview and push a new try [2]. If the crashes have vanished we could move forward with a review request. Otherwise I'll leave the bug for someone else.

[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=15e850234416bf7d0867bc38d1c8d2314e184cff
[2] https://treeherder.mozilla.org/#/jobs?repo=try&revision=be96f6395025d327e905be42288d84c0038f8d7e

Comment 6

[Julien Wajsberg [:julienw]]

There is still a crash and I don't think I have the necessary knowledge to find the reason :( Unassigning.

Comment 7

[Rob Wu [:robwu]]

This bug is about this line: https://searchfox.org/mozilla-central/rev/919607a3610222099fbfb0113c98b77888ebcbfb/devtools/server/actors/webconsole/content-process-forward.js#96

This doesn't look like an extensions bug, moving over to the correct product/component.