Closed Bug 1383124 Opened 8 years ago Closed 8 years ago

Remove problematic assertion from windows AccessibleWrap

Categories

(Core :: Disability Access APIs, enhancement)

Product:
Core
Component:
Disability Access APIs
Platform:
Unspecified
Windows
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla56
Tracking Flags:
Tracking Status
firefox56 --- fixed

People

(Reporter: bugzilla, Assigned: bugzilla)

Details

Attachments

(1 file)

Remove the assertion
1.44 KB, patch
eeejay
: review+
Details | Diff | Splinter Review
I have spoken to Jamie about this and it is expected for NVDA to do the very thing that the assertion is checking for. Hitting that assertion is all but guaranteed in DEBUG builds, so we should just get rid of it.
Comment on attachment 8888845 [details] [diff] [review] Remove the assertion Review of attachment 8888845 [details] [diff] [review]: ----------------------------------------------------------------- Looks good. Sorry for the delay!
Attachment #8888845 - Flags: review?(eitan) → review+
Accidentally landed this under bug 1379951 https://hg.mozilla.org/integration/mozilla-inbound/rev/f376e1ee725c5938a11b2a8e28d959afdd6bef47 https://hg.mozilla.org/mozilla-central/rev/f376e1ee725c
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: