Remove problematic assertion from windows AccessibleWrap

RESOLVED FIXED in Firefox 56

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: aklotz, Assigned: aklotz)

Tracking

Trunk
mozilla56
Unspecified
Windows
Points:
---

Firefox Tracking Flags

(firefox56 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
I have spoken to Jamie about this and it is expected for NVDA to do the very thing that the assertion is checking for.

Hitting that assertion is all but guaranteed in DEBUG builds, so we should just get rid of it.
(Assignee)

Comment 1

2 years ago
Created attachment 8888845 [details] [diff] [review]
Remove the assertion

Jamie's comments are in https://bugzilla.mozilla.org/show_bug.cgi?id=1374632#c10
Attachment #8888845 - Flags: review?(eitan)
Comment on attachment 8888845 [details] [diff] [review]
Remove the assertion

Review of attachment 8888845 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Sorry for the delay!
Attachment #8888845 - Flags: review?(eitan) → review+
(Assignee)

Comment 3

2 years ago
Accidentally landed this under bug 1379951
https://hg.mozilla.org/integration/mozilla-inbound/rev/f376e1ee725c5938a11b2a8e28d959afdd6bef47
https://hg.mozilla.org/mozilla-central/rev/f376e1ee725c
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.