Closed Bug 1383131 Opened 3 years ago Closed 3 years ago

compatiblity.cpp assertion on Windows 7

Categories

(Core :: Disability Access APIs, defect, P2)

Unspecified
Windows 7
defect

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox57 --- fixed
firefox58 --- fixed

People

(Reporter: aklotz, Assigned: aklotz)

References

Details

(Whiteboard: [aes+])

Attachments

(1 file)

My hack from bug 1310056 has a mistake in that it is looking for combase.dll, which doesn't exist on Windows 7. We probably need ole32.dll in that case.
Priority: -- → P2
Whiteboard: [aes?]
Whiteboard: [aes?] → [aes+]
Attached patch FixSplinter Review
This adds support for Windows 7 and also makes the enabling of this feature more aggressive -- it also kicks in as needed for unknown clients.
Attachment #8920698 - Flags: review?(dbolter)
Comment on attachment 8920698 [details] [diff] [review]
Fix

Looks good.
Attachment #8920698 - Flags: review?(dbolter) → review+
https://hg.mozilla.org/mozilla-central/rev/cea8af673cec
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Comment on attachment 8920698 [details] [diff] [review]
Fix

Approval Request Comment
[Feature/Bug causing the regression]: a11y+e10s
[User impact if declined]: Some a11y clients that worked in previous Firefox releases will stop working on Windows 7
[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Really simple change
[String changes made/needed]: None
Attachment #8920698 - Flags: approval-mozilla-beta?
Comment on attachment 8920698 [details] [diff] [review]
Fix

e10s+a11y related, Beta57+
Attachment #8920698 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
(In reply to Aaron Klotz [:aklotz] (a11y work receiving priority right now, please send interceptor reviews to dmajor or handyman) from comment #5)
> [Is this code covered by automated tests?]: Yes
> [Has the fix been verified in Nightly?]: Yes
> [Needs manual test from QE? If yes, steps to reproduce]: No

Setting qe-verify- based on Aaron's assessment on manual testing needs and the fact that this fix has automated coverage.
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.