1383131 - compatiblity.cpp assertion on Windows 7

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect, P2)

Description

[(No longer employed by Mozilla) Aaron Klotz]

My hack from bug 1310056 has a mistake in that it is looking for combase.dll, which doesn't exist on Windows 7. We probably need ole32.dll in that case.

Comment 1

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Fix

This adds support for Windows 7 and also makes the enabling of this feature more aggressive -- it also kicks in as needed for unknown clients.

Comment 2

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 8920698 [details] [diff] [review]
Fix

Looks good.

Comment 3

[(No longer employed by Mozilla) Aaron Klotz]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cea8af673cece90d538a0fc4782aa1b15aa6c020
Bug 1383131: Fall back to ole32.dll if combase.dll is not present; r=davidb

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/cea8af673cec

Comment 5

[(No longer employed by Mozilla) Aaron Klotz]

Comment on attachment 8920698 [details] [diff] [review]
Fix

Approval Request Comment
[Feature/Bug causing the regression]: a11y+e10s
[User impact if declined]: Some a11y clients that worked in previous Firefox releases will stop working on Windows 7
[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Really simple change
[String changes made/needed]: None

Comment 6

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8920698 [details] [diff] [review]
Fix

e10s+a11y related, Beta57+

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/09539becfa9a

Comment 8

[Andrei Vaida [:avaida]]

(In reply to Aaron Klotz [:aklotz] (a11y work receiving priority right now, please send interceptor reviews to dmajor or handyman) from comment #5)
> [Is this code covered by automated tests?]: Yes
> [Has the fix been verified in Nightly?]: Yes
> [Needs manual test from QE? If yes, steps to reproduce]: No

Setting qe-verify- based on Aaron's assessment on manual testing needs and the fact that this fix has automated coverage.