Could the presshell addref in Element::GetBindingURL() be avoided?

RESOLVED FIXED in Firefox 56

Status

()

enhancement
RESOLVED FIXED
2 years ago
2 months ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

unspecified
mozilla56
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox56 fixed)

Details

Attachments

(1 attachment)

It was added in https://hg.mozilla.org/integration/mozilla-inbound/rev/06ac99c8221f#l1.31, and it is showing up in profiles.

Cameron, do we really need this addref?  It seems unnecessary to me.
Flags: needinfo?(cam)
Comment on attachment 8888857 [details] [diff] [review]
Avoid the presshell AddRef() in Element::GetBindingURL()

Review of attachment 8888857 [details] [diff] [review]:
-----------------------------------------------------------------

Seems fine, thanks.
Attachment #8888857 - Flags: review?(cam) → review+
Flags: needinfo?(cam)

Comment 3

2 years ago
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8d7673f2fd2f
Avoid the presshell AddRef() in Element::GetBindingURL(); r=heycam
https://hg.mozilla.org/mozilla-central/rev/8d7673f2fd2f
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Assignee: nobody → ehsan
Component: DOM → DOM: Core & HTML
Product: Core → Core
You need to log in before you can comment on or make changes to this bug.