Closed Bug 1383142 Opened 3 years ago Closed 3 years ago

Could the presshell addref in Element::GetBindingURL() be avoided?

Categories

(Core :: DOM: Core & HTML, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: ehsan, Assigned: ehsan)

References

Details

Attachments

(1 file)

It was added in https://hg.mozilla.org/integration/mozilla-inbound/rev/06ac99c8221f#l1.31, and it is showing up in profiles.

Cameron, do we really need this addref?  It seems unnecessary to me.
Flags: needinfo?(cam)
Comment on attachment 8888857 [details] [diff] [review]
Avoid the presshell AddRef() in Element::GetBindingURL()

Review of attachment 8888857 [details] [diff] [review]:
-----------------------------------------------------------------

Seems fine, thanks.
Attachment #8888857 - Flags: review?(cam) → review+
Flags: needinfo?(cam)
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8d7673f2fd2f
Avoid the presshell AddRef() in Element::GetBindingURL(); r=heycam
https://hg.mozilla.org/mozilla-central/rev/8d7673f2fd2f
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Assignee: nobody → ehsan
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.