Provide easy access to the currently selected tab

RESOLVED FIXED in Firefox 57

Status

()

RESOLVED FIXED
2 years ago
a year ago

People

(Reporter: billm, Assigned: billm)

Tracking

unspecified
mozilla57
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Created attachment 8888993 [details] [diff] [review]
patch

I've decided to make a simplifying assumption for the initial Quantum DOM patches: if only one tab is in the foreground, then we'll label vsyncs correctly for that tab and also prioritize runnables for that tab. If multiple tabs (from multiple windows) are in the foreground, then you won't get any benefit from Quantum DOM. This shouldn't be too hard to fix in the future, but it's a pain to deal with right now.

This patch provides an easy accessor for the foreground TabChild (if there is only one). I imagine other people might find this useful as well for various performance optimizations.
Attachment #8888993 - Flags: review?(dvander)
Attachment #8888993 - Flags: review?(dvander) → review+
Summary: Provide easy access to the currently selected tab (when there is only one) → Provide easy access to the currently selected tab
Created attachment 8899011 [details] [diff] [review]
patch v2

I realized that we do need to keep track of multiple active tabs. When tab switching, for example, two tabs can be active at once. And that's specifically a case where I would like the Quantum DOM scheduler to be effective.

David is on PTO, so asking Kan-Ru for review.
Attachment #8888993 - Attachment is obsolete: true
Attachment #8899011 - Flags: review?(kchen)
Attachment #8899011 - Flags: review?(kchen) → review+

Comment 2

a year ago
Pushed by wmccloskey@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7f426b4432ff
Keep track of foreground TabChildren (r=kanru)

Comment 3

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/7f426b4432ff
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.