1383361 - Text size is too small on (new) onboarding

Status: VERIFIED FIXED

(Firefox for iOS :: General, defect, P1)

Description

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

On a 7+ the text size of the onboarding is smaller than the old onboarding slides. The Start Browsing text is so small that it is hard to read. Maybe a 7+ specific scaling issue?

Comment 1

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

I may also have turned down my dynamic text scaling all the way when i saw this.

Comment 2

[Farhan Patel [:farhan]]

Attachment: Pull Request

Comment 3

[Farhan Patel [:farhan]]

Although, Stefan if you had turned down your text scaling when you saw this my PR wont fix that issue. If the user is setting a smaller font in Settings sometimes things might just be too small.

Comment 4

[Farhan Patel [:farhan]]

Attachment: onboarding iphone7plus.png

Comment 5

[Farhan Patel [:farhan]]

Attachment: onboarding iPhone SE.png

Both of the screenshots represents the Intro cards after the patch.

Comment 6

[Farhan Patel [:farhan]]

master https://github.com/mozilla-mobile/firefox-ios/commit/7316eee29ce5fbf8e09d6ad14c7b1362cfb9f30d
uplifted to v9.x

Comment 7

[Simon Basca [:SimonB]]

Verifying as fix on master 246293a0ba and 9.0(5725).