1383416 - Slow startup and high resource usage during startup

Status: RESOLVED WORKSFORME

(Firefox :: Session Restore, defect, P4)

Description

[Wayne Mery (:wsmwk)]

I took a big jump in nightlies, from 06-25 to 07-20 (and now on 07-22), and session restore stinks (sorry). I've not seen it this bad for a few years.

300+ tabs UI during startup is now unresponsive and hammers the crap out of my SSD machine for about a minute or two. It also kills responsiveness of all other applications. I'll have to get more details, perhaps get a regression range because I'm not at all sure it is related to bug 934967, nor can I yet rule out addons. (Tree Style Tabs has been an issue a couple times in the past couple years)

Comment 1

[Dietrich Ayala (:dietrich)]

Hi Wayne,

By all accounts this particular scenario is something Firefox should be *fantastically* better at since the lazy tab work landed. Today I restarted and Firefox was responsive and ready to go w/ 339 tabs in under 10 seconds.

Interestingly, I'm tracking down a similar issue with someone else who is seeing similar behavior as you... and they're a TST fan also. That said, it could be any number of things, even some corrupted data in your profile or something tickling all the tabs so that they're not lazy anymore.

To start, it would be super helpful if you could create a new profile, copy all your current profile's files into it, and then in that new profile, disable all add-ons and plugins and see if the problem still happens.

Comment 2

[Wayne Mery (:wsmwk)]

Attachment: Firefox-bug1383416-troubleshooting.txt

copied profile and deleted all extensions related files and directories.  
benchmarked with 2017-07-28 64bit nightly, 355 tabs. dom.ipc.processes=9.
CPU is quad i7 2.40 GHz.
have not yet tested with only treestyletabs removed. (it is a likely culprit)

Results, both with and without extensions, were not as bad as reported in comment 0 - i.e. Windows was not locked up.  In both cases FIRST firefox window appears roughly immediately.  Then, there are several seconds of no window activity until (apparently) it is done parsing sessionstore - then starts displaying windows. 

Summary:
- WITH all extensions, everything is approximately 50% longer.
- NO extensions, did not load anywhere near as fast as yours (with similar quantity of tabs)

                             NO  
                         extensions   extensions
1. starts populating         12           20
2. windows+tabs populated  30-35          60
3. stable (activity dies)   ~75          ~75

Notes: 
* #3 is very subjective, by looking at CPU graph
* memory usage roughly the same in both with and without addons
* able to manually open new windows shortly (5-10 seconds?) before #2
* system was not fully idle - chrome and thunderbird are running, but no real activity - nominal 2-3% CPU usage

Comment 3

[Wayne Mery (:wsmwk)]

Attachment: ff-bug1383416-sessionstore.png

attached is screen shot of the top of about:sessionstore.

notable, there is at least one additional depth/nesting of sessions. possibly two. i.e. there is at least one unexpanded about:sessionrestore

Comment 4

[Wayne Mery (:wsmwk)]

So, I cannot reproduce the horrible results of comment 0 both with and without extensions - which I suppose is a good thing. (AFAIK I am using the same version of TST now as I did in comment 0. But I didn't test with the exact same build as comment 0, test build was 4 days newer.)  

But I don't get your 10 second startup time with no extensions.  So I am willing to do more testing.

Regarding TST, I know it is not webextension enabled - https://github.com/piroor/treestyletab/issues/1224
And there is an update available 0.19.2017081600a122011, but afaict it does not in the past month fix any performance issues https://github.com/piroor/treestyletab/issues?q=is%3Aissue+is%3Aclosed

Comment 5

[Graham Perrin]

## e10s

Wayne, please: can you recall whether multiprocess was enabled whenever slowness occurred?

Now – with your current set of extensions – is multiprocess enabled? 

----

Note to self: Bug 1394225

Comment 6

[Wayne Mery (:wsmwk)]

I have been running with dom.ipc.processes = 9 for many (9?) months. and before that, I think 6.  ref. attachment 8901456 [details]
I also have extensions.legacy.enabled = true

Comment 7

[Mike de Boer [:mikedeboer]]

(In reply to Wayne Mery (:wsmwk, NI for questions) from comment #6)
> I also have extensions.legacy.enabled = true

Yes, so this could also be happening due to an existing causing a force-insertion of browser elements... which could potentially make the the restore process even slower than it was before lazy tabs were introduced.

I'm betting this behavior doesn't occur with all extensions disabled and extensions.legacy.enabled = false, right?

Comment 8

[Wayne Mery (:wsmwk)]

I am still running 56.0a1 and haven't seen this with newer versions of addons