1383641 - GetFlatTextLengthInRange shouldn't use nsIDOMNode version of nsRange.SetStart

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Makoto Kato [:m_kato]]

nsGenericDOMDataNode::SetData uses GetFlatTextLengthInRange.  But GetFlatTextLengthInRange still use nsIDOMNode.  It mean that we need additional QI.  So we should use nsINode version instead.

Comment 1

[Makoto Kato [:m_kato]]

Attachment: Bug 1383641 - GetFlatTextLengthInRange shouldn't use nsIDOMNode version of nsRange::SetStart.

nsGenericDOMDataNode::SetData uses GetFlatTextLengthInRange.  But GetFlatTextLengthInRange still use nsIDOMNode.  It means that we need additional QI twice.  So we should use nsINode version directly instead.

Review commit: https://reviewboard.mozilla.org/r/160426/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/160426/

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8890142 [details]
Bug 1383641 - GetFlatTextLengthInRange shouldn't use nsIDOMNode version of nsRange::SetStart.

https://reviewboard.mozilla.org/r/160426/#review166592

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1234b6349697
GetFlatTextLengthInRange shouldn't use nsIDOMNode version of nsRange::SetStart. r=masayuki

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1234b6349697