1383655 - Instead of copy/save ALL (requests) as HAR consider just copy/save all the FILTERED ones

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect, P3)

Description

[Aquila]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:54.0) Gecko/20100101 Firefox/54.0
Build ID: 20170628075643

Steps to reproduce:

I filter the requests in the network panel for only XHR requests and then I choose to same all the requests as HAR file.


Actual results:

It saves all the requests included the filtered out requests (HTML, CSS, JS, etc.)


Expected results:

Yup, I was hoping to save all the filtered requests, most probably the "all" refers to all requests and not to all visible requests in the panel, which means only to filtered ones.

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: Bug 1383655 - Copy as HAR only displayed requests;

Review commit: https://reviewboard.mozilla.org/r/228258/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/228258/

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

@jryans: it's rather small patch, but let me know if I should
assign the review to someone else.
Thanks,
Honza

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8959448 [details]
Bug 1383655 - Copy as HAR only displayed requests;

https://reviewboard.mozilla.org/r/228258/#review234218

Looks reasonable to me! :) Thanks for working on it.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4f8555238756
Copy as HAR only displayed requests; r=jryans

Comment 5

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/4f8555238756