Closed Bug 1383719 Opened 3 years ago Closed 3 years ago
General - Updates section - no changes are visible in the latest build
[Affected versions]: Nightly 56.0a1, Build ID 20170723100358 [Affected platforms]: Platforms: Windows 10 x 64 and Mac OS X 10.12 [Steps to reproduce]: 1. Launch Nightly 2. Go to "about:preferences" 3. In the General tab check "Updates" section [Expected result]: Updates section is changed and reorganised (attached screenshot) per preferences reorg. document [Actual result]: Updates section is displayed as before - with no changes implemented in the latest build.
Assignee: nobody → evan
Status: NEW → ASSIGNED
Priority: -- → P1
Hi Jared, Could you help review the patch? Thank you.
Comment on attachment 8889761 [details] Bug 1383719 - Update and add strings for the Updates section. Hi Helen, Could you review the UI change? Thank you.
Attachment #8889761 - Flags: ui-review?(hhuang)
The screenshot: https://bugzilla.mozilla.org/show_bug.cgi?id=1383719
Comment on attachment 8889761 [details] Bug 1383719 - Update and add strings for the Updates section. The visual looks okay to me, thanks!
Attachment #8889761 - Flags: ui-review?(hhuang) → ui-review+
Comment on attachment 8889761 [details] Bug 1383719 - Update and add strings for the Updates section. https://reviewboard.mozilla.org/r/160840/#review166484
Attachment #8889761 - Flags: review?(jaws) → review+
Thank you for reviewing, Jared. And the try looks good. Let's land it. : https://treeherder.mozilla.org/#/jobs?repo=try&revision=d3dc63fc4f30
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/1528aa401501 Update and add strings for the Updates section. r=jaws
Verified on latest Nightly 56.0a1, Build ID 20170726155629 on Windows 10, Ubuntu 16.04 and Mac OS X 10.12. Updates section strings are updated, but still, I observed two issues: 1. On the line with Firefox build version - it is present the build date: "Version 56.0a1 (2017-07-26) (32-bit)" and in documentation is specified "Version: 53.0 (64-bit)" Is this the intended behavior? Should we have the date present for Nightly builds? 2. On Windows OS-es, there is one more check box: "Use a background service to install updates". Is this correct? Should this option be present on Windows OS-ses?
Hi Brindusa, The version information is different between Nightly and Firefox. The spec is for Firefox, so showing "Version 56.0a1 (2017-07-26) (32-bit)" is OK in Nighlty since it's exactly the Nightly's version information. Sorry for not indicating all the differences of version information on spec! And the additional option on Windows is OK as well :)
Based on previous comments, marking this verified as fixed.
You need to log in before you can comment on or make changes to this bug.