1383719 - General - Updates section - no changes are visible in the latest build

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P1)

Description

[Deac Alin]

Attachment: Updates changes.png

[Affected versions]: 
Nightly 56.0a1, Build ID 20170723100358

[Affected platforms]:
Platforms: Windows 10 x 64 and Mac OS X 10.12

[Steps to reproduce]:
1. Launch Nightly
2. Go to "about:preferences"
3. In the General tab check "Updates" section

[Expected result]:
Updates section is changed and reorganised (attached screenshot) per preferences reorg. document

[Actual result]:
Updates section is displayed as before - with no changes implemented in the latest build.

Comment 1

[Evan Tseng [:evanxd]]

Attachment: Bug 1383719 - Update and add strings for the Updates section.

Review commit: https://reviewboard.mozilla.org/r/160840/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/160840/

Comment 2

[Evan Tseng [:evanxd]]

Comment on attachment 8889761 [details]
Bug 1383719 - Update and add strings for the Updates section.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/160840/diff/1-2/

Comment 3

[Evan Tseng [:evanxd]]

Comment on attachment 8889761 [details]
Bug 1383719 - Update and add strings for the Updates section.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/160840/diff/2-3/

Comment 4

[Evan Tseng [:evanxd]]

Hi Jared,

Could you help review the patch?

Thank you.

Comment 5

[Evan Tseng [:evanxd]]

Attachment: updates-section.png

Comment 6

[Evan Tseng [:evanxd]]

Comment on attachment 8889761 [details]
Bug 1383719 - Update and add strings for the Updates section.

Hi Helen,

Could you review the UI change?

Thank you.

Comment 7

[Evan Tseng [:evanxd]]

The screenshot: https://bugzilla.mozilla.org/show_bug.cgi?id=1383719

Comment 8

[Helen Huang [:HHuang]]

Comment on attachment 8889761 [details]
Bug 1383719 - Update and add strings for the Updates section.

The visual looks okay to me, thanks!

Comment 9

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8889761 [details]
Bug 1383719 - Update and add strings for the Updates section.

https://reviewboard.mozilla.org/r/160840/#review166484

Comment 10

[Evan Tseng [:evanxd]]

Thank you for reviewing, Jared. And the try[1] looks good. Let's land it.

[1]: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d3dc63fc4f30

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1528aa401501
Update and add strings for the Updates section. r=jaws

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1528aa401501

Comment 13

[Brindusa Tot, Desktop QA]

Verified on latest Nightly 56.0a1, Build ID 20170726155629 on Windows 10, Ubuntu 16.04 and Mac OS X 10.12.

Updates section strings are updated, but still, I observed two issues:
1. On the line with Firefox build version - it is present the build date:
"Version 56.0a1 (2017-07-26) (32-bit)"
and in documentation is specified
"Version: 53.0 (64-bit)" 

Is this the intended behavior? Should we have the date present for Nightly builds?

2. On Windows OS-es, there is one more check box:
"Use a background service to install updates".
Is this correct? Should this option be present on Windows OS-ses?

Comment 14

[Tina Hsieh[:Tina_Hsieh] UX]

Hi Brindusa,
The version information is different between Nightly and Firefox. The spec is for Firefox, so showing "Version 56.0a1 (2017-07-26) (32-bit)" is OK in Nighlty since it's exactly the Nightly's version information. Sorry for not indicating all the differences of version information on spec!

And the additional option on Windows is OK as well :)

Comment 15

[Brindusa Tot, Desktop QA]

Based on previous comments, marking this verified as fixed.