General - Updates section - no changes are visible in the latest build

VERIFIED FIXED in Firefox 56

Status

()

Firefox
Preferences
P1
normal
VERIFIED FIXED
a month ago
27 days ago

People

(Reporter: Deac Alin, Assigned: evanxd)

Tracking

56 Branch
Firefox 56
Points:
---
Bug Flags:
qe-verify +

Firefox Tracking Flags

(firefox56 verified)

Details

(Whiteboard: [photon-preference])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(3 attachments)

(Reporter)

Description

a month ago
Created attachment 8889414 [details]
Updates changes.png

[Affected versions]: 
Nightly 56.0a1, Build ID 20170723100358

[Affected platforms]:
Platforms: Windows 10 x 64 and Mac OS X 10.12

[Steps to reproduce]:
1. Launch Nightly
2. Go to "about:preferences"
3. In the General tab check "Updates" section

[Expected result]:
Updates section is changed and reorganised (attached screenshot) per preferences reorg. document

[Actual result]:
Updates section is displayed as before - with no changes implemented in the latest build.
(Reporter)

Updated

a month ago
Blocks: 1365133
Whiteboard: [photon-preference]
(Assignee)

Updated

a month ago
Assignee: nobody → evan
Status: NEW → ASSIGNED
Priority: -- → P1
(Assignee)

Updated

a month ago
Flags: qe-verify+
QA Contact: hani.yacoub
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Updated

a month ago
Attachment #8889761 - Flags: review?(jaws)
(Assignee)

Comment 4

a month ago
Hi Jared,

Could you help review the patch?

Thank you.
(Assignee)

Comment 5

a month ago
Created attachment 8889772 [details]
updates-section.png
(Assignee)

Comment 6

a month ago
Comment on attachment 8889761 [details]
Bug 1383719 - Update and add strings for the Updates section.

Hi Helen,

Could you review the UI change?

Thank you.
Attachment #8889761 - Flags: ui-review?(hhuang)
(Assignee)

Comment 7

a month ago
The screenshot: https://bugzilla.mozilla.org/show_bug.cgi?id=1383719
Comment on attachment 8889761 [details]
Bug 1383719 - Update and add strings for the Updates section.

The visual looks okay to me, thanks!
Attachment #8889761 - Flags: ui-review?(hhuang) → ui-review+

Updated

a month ago
Target Milestone: --- → Firefox 56

Comment 9

29 days ago
mozreview-review
Comment on attachment 8889761 [details]
Bug 1383719 - Update and add strings for the Updates section.

https://reviewboard.mozilla.org/r/160840/#review166484
Attachment #8889761 - Flags: review?(jaws) → review+
(Assignee)

Comment 10

29 days ago
Thank you for reviewing, Jared. And the try[1] looks good. Let's land it.

[1]: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d3dc63fc4f30
Keywords: checkin-needed

Comment 11

29 days ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/1528aa401501
Update and add strings for the Updates section. r=jaws
Keywords: checkin-needed

Comment 12

29 days ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/1528aa401501
Status: ASSIGNED → RESOLVED
Last Resolved: 29 days ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Verified on latest Nightly 56.0a1, Build ID 20170726155629 on Windows 10, Ubuntu 16.04 and Mac OS X 10.12.

Updates section strings are updated, but still, I observed two issues:
1. On the line with Firefox build version - it is present the build date:
"Version 56.0a1 (2017-07-26) (32-bit)"
and in documentation is specified
"Version: 53.0 (64-bit)" 

Is this the intended behavior? Should we have the date present for Nightly builds?

2. On Windows OS-es, there is one more check box:
"Use a background service to install updates".
Is this correct? Should this option be present on Windows OS-ses?
Flags: needinfo?(evan)
Hi Brindusa,
The version information is different between Nightly and Firefox. The spec is for Firefox, so showing "Version 56.0a1 (2017-07-26) (32-bit)" is OK in Nighlty since it's exactly the Nightly's version information. Sorry for not indicating all the differences of version information on spec!

And the additional option on Windows is OK as well :)
Flags: needinfo?(evan)
Based on previous comments, marking this verified as fixed.
Status: RESOLVED → VERIFIED
status-firefox56: fixed → verified
You need to log in before you can comment on or make changes to this bug.