1383741 - Perma failure when 56 merge to beta in browser_experiments.js | Test timed out -

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect, P1)

Description

[Carsten Book [:Tomcat]]

found via uplift simulations - perma failure when 56 merge to beta next week like  TEST-UNEXPECTED-FAIL | toolkit/mozapps/extensions/test/browser/browser_experiments.js | Test timed out -  https://treeherder.mozilla.org/logviewer.html#?job_id=116829771&repo=try

maybe related to bug 1365133 ?

Comment 1

[Carsten Book [:Tomcat]]

evan: could you take a look, thanks!

Comment 2

[Evan Tseng [:evanxd]]

Attachment: Bug 1383741 - Ensure browser_experiments.js works with both new and old Preferences UI.

Review commit: https://reviewboard.mozilla.org/r/160896/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/160896/

Comment 3

[Evan Tseng [:evanxd]]

Comment on attachment 8889806 [details]
Bug 1383741 - Ensure browser_experiments.js works with both new and old Preferences UI.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/160896/diff/1-2/

Comment 4

[Evan Tseng [:evanxd]]

Hi Mike,

Could you help review the patch?

Thank you.

Comment 5

[Evan Tseng [:evanxd]]

Comment on attachment 8889806 [details]
Bug 1383741 - Ensure browser_experiments.js works with both new and old Preferences UI.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/160896/diff/2-3/

Comment 6

[Evan Tseng [:evanxd]]

Hi Tomcat,

I think the patch could fix the issue. Could you help me push a try with patch in beta build to confirm the fix, or tell me how to do it?

Thank you.

Comment 7

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Just pull the beta branch |hg pull -r beta| and |hg graft| your commit on top of it, and push to Try.

Comment 8

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to Tim Guan-tin Chien [:timdream] (please needinfo) from comment #7)
> Just pull the beta branch |hg pull -r beta| and |hg graft| your commit on
> top of it, and push to Try.

I am sorry, that's for testing an uplift.

To test this bug you will need to look at what cbook had done in the rev he pointed at comment 0

https://treeherder.mozilla.org/#/jobs?repo=try&revision=04c46c8df2cab30419bbea1b27d8c68831e27ca1&selectedJob=116829771

and do so accordingly. I thought you remember that given that you've already done it before...

Comment 9

[Evan Tseng [:evanxd]]

The 'browser_experiments.js' test is passed on the try task[1].

Thanks for the explanation, Tim.

[1]: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2d4509c9d0d18fe92f4a2eea7600cfb5a6a0142d&selectedJob=117876748

Comment 10

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8889806 [details]
Bug 1383741 - Ensure browser_experiments.js works with both new and old Preferences UI.

https://reviewboard.mozilla.org/r/160896/#review166786

::: commit-message-dcfb5:1
(Diff revision 3)
> +Bug 1383741 - Close advanced pane in old prefs.

Nit - mind updating this commit message with a little more detail? Perhaps something like:

Bug 1383741 - Ensure browser_experiments.js works with both new and old Preferences UI

Comment 11

[Evan Tseng [:evanxd]]

Comment on attachment 8889806 [details]
Bug 1383741 - Ensure browser_experiments.js works with both new and old Preferences UI.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/160896/diff/3-4/

Comment 12

[Evan Tseng [:evanxd]]

Comment on attachment 8889806 [details]
Bug 1383741 - Ensure browser_experiments.js works with both new and old Preferences UI.

https://reviewboard.mozilla.org/r/160896/#review166786

> Nit - mind updating this commit message with a little more detail? Perhaps something like:
> 
> Bug 1383741 - Ensure browser_experiments.js works with both new and old Preferences UI

Sure, let's do it.

Comment 13

[Evan Tseng [:evanxd]]

Thank you for reviewing, Mike. Let's land it.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f29c950fa226
Ensure browser_experiments.js works with both new and old Preferences UI. r=mconley

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f29c950fa226