Closed Bug 1383741 Opened 2 years ago Closed 2 years ago

Perma failure when 56 merge to beta in browser_experiments.js | Test timed out -

Categories

(Firefox :: Preferences, defect, P1, blocker)

defect

Tracking

()

RESOLVED FIXED
Firefox 56
Tracking Status
firefox56 ? fixed

People

(Reporter: cbook, Assigned: evanxd)

References

()

Details

(Whiteboard: [photon-preference])

Attachments

(1 file)

found via uplift simulations - perma failure when 56 merge to beta next week like  TEST-UNEXPECTED-FAIL | toolkit/mozapps/extensions/test/browser/browser_experiments.js | Test timed out -  https://treeherder.mozilla.org/logviewer.html#?job_id=116829771&repo=try

maybe related to bug 1365133 ?
evan: could you take a look, thanks!
Flags: needinfo?(evan)
Assignee: nobody → evan
Status: NEW → ASSIGNED
Flags: qe-verify-
Priority: -- → P1
Whiteboard: [photon-preference]
Target Milestone: --- → Firefox 56
Attachment #8889806 - Flags: review?(mconley)
Hi Mike,

Could you help review the patch?

Thank you.
Flags: needinfo?(evan)
Blocks: 1365133
Hi Tomcat,

I think the patch could fix the issue. Could you help me push a try with patch in beta build to confirm the fix, or tell me how to do it?

Thank you.
Flags: needinfo?(cbook)
Just pull the beta branch |hg pull -r beta| and |hg graft| your commit on top of it, and push to Try.
Flags: needinfo?(cbook)
(In reply to Tim Guan-tin Chien [:timdream] (please needinfo) from comment #7)
> Just pull the beta branch |hg pull -r beta| and |hg graft| your commit on
> top of it, and push to Try.

I am sorry, that's for testing an uplift.

To test this bug you will need to look at what cbook had done in the rev he pointed at comment 0

https://treeherder.mozilla.org/#/jobs?repo=try&revision=04c46c8df2cab30419bbea1b27d8c68831e27ca1&selectedJob=116829771

and do so accordingly. I thought you remember that given that you've already done it before...
The 'browser_experiments.js' test is passed on the try task[1].

Thanks for the explanation, Tim.

[1]: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2d4509c9d0d18fe92f4a2eea7600cfb5a6a0142d&selectedJob=117876748
Comment on attachment 8889806 [details]
Bug 1383741 - Ensure browser_experiments.js works with both new and old Preferences UI.

https://reviewboard.mozilla.org/r/160896/#review166786

::: commit-message-dcfb5:1
(Diff revision 3)
> +Bug 1383741 - Close advanced pane in old prefs.

Nit - mind updating this commit message with a little more detail? Perhaps something like:

Bug 1383741 - Ensure browser_experiments.js works with both new and old Preferences UI
Attachment #8889806 - Flags: review?(mconley) → review+
Comment on attachment 8889806 [details]
Bug 1383741 - Ensure browser_experiments.js works with both new and old Preferences UI.

https://reviewboard.mozilla.org/r/160896/#review166786

> Nit - mind updating this commit message with a little more detail? Perhaps something like:
> 
> Bug 1383741 - Ensure browser_experiments.js works with both new and old Preferences UI

Sure, let's do it.
Thank you for reviewing, Mike. Let's land it.
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/f29c950fa226
Ensure browser_experiments.js works with both new and old Preferences UI. r=mconley
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/f29c950fa226
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.