Perma failure when 56 merge to beta in browser_experiments.js | Test timed out -

RESOLVED FIXED in Firefox 56

Status

()

Firefox
Preferences
P1
blocker
RESOLVED FIXED
4 months ago
4 months ago

People

(Reporter: Tomcat, Assigned: evanxd)

Tracking

unspecified
Firefox 56
Points:
---
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox56? fixed)

Details

(Whiteboard: [photon-preference], URL)

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

4 months ago
found via uplift simulations - perma failure when 56 merge to beta next week like  TEST-UNEXPECTED-FAIL | toolkit/mozapps/extensions/test/browser/browser_experiments.js | Test timed out -  https://treeherder.mozilla.org/logviewer.html#?job_id=116829771&repo=try

maybe related to bug 1365133 ?
(Reporter)

Comment 1

4 months ago
evan: could you take a look, thanks!
tracking-firefox56: --- → ?
Flags: needinfo?(evan)

Updated

4 months ago
Assignee: nobody → evan
Status: NEW → ASSIGNED
Flags: qe-verify-
Priority: -- → P1
Whiteboard: [photon-preference]
Target Milestone: --- → Firefox 56
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Updated

4 months ago
Attachment #8889806 - Flags: review?(mconley)
(Assignee)

Comment 4

4 months ago
Hi Mike,

Could you help review the patch?

Thank you.
Flags: needinfo?(evan)
(Assignee)

Updated

4 months ago
Blocks: 1365133
Comment hidden (mozreview-request)
(Assignee)

Comment 6

4 months ago
Hi Tomcat,

I think the patch could fix the issue. Could you help me push a try with patch in beta build to confirm the fix, or tell me how to do it?

Thank you.
Flags: needinfo?(cbook)
Just pull the beta branch |hg pull -r beta| and |hg graft| your commit on top of it, and push to Try.
Flags: needinfo?(cbook)
(In reply to Tim Guan-tin Chien [:timdream] (please needinfo) from comment #7)
> Just pull the beta branch |hg pull -r beta| and |hg graft| your commit on
> top of it, and push to Try.

I am sorry, that's for testing an uplift.

To test this bug you will need to look at what cbook had done in the rev he pointed at comment 0

https://treeherder.mozilla.org/#/jobs?repo=try&revision=04c46c8df2cab30419bbea1b27d8c68831e27ca1&selectedJob=116829771

and do so accordingly. I thought you remember that given that you've already done it before...
(Assignee)

Comment 9

4 months ago
The 'browser_experiments.js' test is passed on the try task[1].

Thanks for the explanation, Tim.

[1]: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2d4509c9d0d18fe92f4a2eea7600cfb5a6a0142d&selectedJob=117876748
Comment on attachment 8889806 [details]
Bug 1383741 - Ensure browser_experiments.js works with both new and old Preferences UI.

https://reviewboard.mozilla.org/r/160896/#review166786

::: commit-message-dcfb5:1
(Diff revision 3)
> +Bug 1383741 - Close advanced pane in old prefs.

Nit - mind updating this commit message with a little more detail? Perhaps something like:

Bug 1383741 - Ensure browser_experiments.js works with both new and old Preferences UI
Attachment #8889806 - Flags: review?(mconley) → review+
Comment hidden (mozreview-request)
(Assignee)

Comment 12

4 months ago
mozreview-review-reply
Comment on attachment 8889806 [details]
Bug 1383741 - Ensure browser_experiments.js works with both new and old Preferences UI.

https://reviewboard.mozilla.org/r/160896/#review166786

> Nit - mind updating this commit message with a little more detail? Perhaps something like:
> 
> Bug 1383741 - Ensure browser_experiments.js works with both new and old Preferences UI

Sure, let's do it.
(Assignee)

Comment 13

4 months ago
Thank you for reviewing, Mike. Let's land it.
Keywords: checkin-needed

Comment 14

4 months ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/f29c950fa226
Ensure browser_experiments.js works with both new and old Preferences UI. r=mconley
Keywords: checkin-needed
(Reporter)

Comment 15

4 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/f29c950fa226
Status: ASSIGNED → RESOLVED
Last Resolved: 4 months ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.