Closed
Bug 1383765
Opened 7 years ago
Closed 7 years ago
[LeanPlum] Tapping the "+" icon to open a new tab, doesn't trigger the Focus promotion
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox56 fixed)
RESOLVED
FIXED
Firefox 56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: ohorvath, Assigned: cnevinchen)
References
Details
(Whiteboard: [LP_M1])
Attachments
(1 file)
Device: HTC Nexus 9 (Android 7.1.1) Build: Nightly 56.0a1 (2017-07-24); Prerequisites: LeanPlum is turned on in Switchboard. Focus is not installed on the device. Steps to reproduce: 1. Open Fennec. 2. On a tablet, tap the + icon to open a new tab. Expected result: The Focus promotion is displayed when a new tab is opened. Actual result: Focus promotion is only displayed when you open tabs from the custom menu or from the tabs tray. Not displayed when opening a new tab from the + icon on tablets.
Assignee | ||
Comment 1•7 years ago
|
||
Hi Oana Thanks for the report. Tablet was not considered in the first planing. Maybe we should add them
Flags: needinfo?(jcollings)
Comment 2•7 years ago
|
||
(In reply to Nevin Chen [:nechen] from comment #1) > Hi Oana > Thanks for the report. > Tablet was not considered in the first planing. Maybe we should add them Nevin is there a way to have the promo display when they hit new tab from the + icon on tablets?
Flags: needinfo?(jcollings)
Comment hidden (mozreview-request) |
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8889712 [details] Bug 1383765 - Add Leanplum event for new tab for Tablet. https://reviewboard.mozilla.org/r/160776/#review166026 LGTM
Attachment #8889712 -
Flags: review?(max) → review+
Pushed by nechen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4809c54d1cec Add Leanplum event for new tab for Tablet. r=maliu
Assignee | ||
Comment 6•7 years ago
|
||
This is a small fix and should be fine even now is soft code freeze. So I'll just land this.
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → cnevinchen
Comment 7•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/4809c54d1cec
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
Updated•7 years ago
|
Whiteboard: [LP_M2]
Updated•7 years ago
|
Whiteboard: [LP_M2] → [LP_M1]
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•