Closed Bug 1383765 Opened 2 years ago Closed 2 years ago
Plum] Tapping the "+" icon to open a new tab, doesn't trigger the Focus promotion
59 bytes, text/x-review-board-request
Device: HTC Nexus 9 (Android 7.1.1) Build: Nightly 56.0a1 (2017-07-24); Prerequisites: LeanPlum is turned on in Switchboard. Focus is not installed on the device. Steps to reproduce: 1. Open Fennec. 2. On a tablet, tap the + icon to open a new tab. Expected result: The Focus promotion is displayed when a new tab is opened. Actual result: Focus promotion is only displayed when you open tabs from the custom menu or from the tabs tray. Not displayed when opening a new tab from the + icon on tablets.
Hi Oana Thanks for the report. Tablet was not considered in the first planing. Maybe we should add them
(In reply to Nevin Chen [:nechen] from comment #1) > Hi Oana > Thanks for the report. > Tablet was not considered in the first planing. Maybe we should add them Nevin is there a way to have the promo display when they hit new tab from the + icon on tablets?
Comment on attachment 8889712 [details] Bug 1383765 - Add Leanplum event for new tab for Tablet. https://reviewboard.mozilla.org/r/160776/#review166026 LGTM
Attachment #8889712 - Flags: review?(max) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/4809c54d1cec Add Leanplum event for new tab for Tablet. r=maliu
This is a small fix and should be fine even now is soft code freeze. So I'll just land this.
You need to log in before you can comment on or make changes to this bug.