1383765 - [LeanPlum] Tapping the "+" icon to open a new tab, doesn't trigger the Focus promotion

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Oana Horvath [:ohorvath - out of office]]

Device: HTC Nexus 9 (Android 7.1.1)
Build: Nightly 56.0a1 (2017-07-24);

Prerequisites: 
LeanPlum is turned on in Switchboard.
Focus is not installed on the device.

Steps to reproduce:
1. Open Fennec.
2. On a tablet, tap the + icon to open a new tab.

Expected result:
The Focus promotion is displayed when a new tab is opened. 

Actual result:
Focus promotion is only displayed when you open tabs from the custom menu or from the tabs tray. Not displayed when opening a new tab from the + icon on tablets.

Comment 1

[Nevin Chen(Not active on Bugzilla)]

Hi Oana
Thanks for the report.
Tablet was not considered in the first planing. Maybe we should add them

Comment 2

[Jean Collings]

(In reply to Nevin Chen [:nechen] from comment #1)
> Hi Oana
> Thanks for the report.
> Tablet was not considered in the first planing. Maybe we should add them

Nevin is there a way to have the promo display when they hit new tab from the + icon on tablets?

Comment 3

[Nevin Chen(Not active on Bugzilla)]

Attachment: Bug 1383765 - Add Leanplum event for new tab for Tablet.

Review commit: https://reviewboard.mozilla.org/r/160776/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/160776/

Comment 4

[Max Liu [:maliu]]

Comment on attachment 8889712 [details]
Bug 1383765 - Add Leanplum event for new tab for Tablet.

https://reviewboard.mozilla.org/r/160776/#review166026

LGTM

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4809c54d1cec
Add Leanplum event for new tab for Tablet. r=maliu

Comment 6

[Nevin Chen(Not active on Bugzilla)]

This is a small fix and should be fine even now is soft code freeze. So I'll just land this.

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4809c54d1cec