If the URL value of a css mask property does not consist of fragment, do not trigger svg resource donwload

RESOLVED FIXED in Firefox 56

Status

()

enhancement
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: u459114, Assigned: u459114)

Tracking

unspecified
mozilla56
Points:
---

Firefox Tracking Flags

(firefox56 fixed)

Details

Attachments

(1 attachment)

Split out from bug 1301245, since there are still several uncerntain things in that bug
Summary: If the URL value of a css mask property does not consist of fragment, do not trigger svg document donwload → If the URL value of a css mask property does not consist of fragment, do not trigger svg resource donwload
Attachment #8889498 - Flags: review?(cam)
Comment on attachment 8889498 [details]
Bug 1383791 -  Download an SVG resource only if the mask URL consists of a fragment.

https://reviewboard.mozilla.org/r/160530/#review166038

r=me if not appending nullptr works.  Otherwise I'd like to understand why.

::: layout/svg/nsSVGEffects.cpp:408
(Diff revision 3)
> +    }
> +
> +    // This URL can not refer to an SVG mask resource if it dose not consist
> +    // of a fragment.
> +    if (!hasRef) {
> +      mProperties.AppendElement(nullptr);

Can we skip appending something, rather than appending nullptr?  Then you wouldn't need the null checks in the users of nsSVGMaskProperty::GetProps.

::: layout/svg/nsSVGEffects.cpp:410
(Diff revision 3)
> +      // nsSVGPaintingProperty's ctor tiggers an external SVG resource
> +      // download, use it only if maskUri has chance pointing to an SVG mask
> +      // resource.

Nit: "has a chance of pointing"
Attachment #8889498 - Flags: review?(cam) → review+
Comment on attachment 8889498 [details]
Bug 1383791 -  Download an SVG resource only if the mask URL consists of a fragment.

https://reviewboard.mozilla.org/r/160530/#review166054

::: layout/svg/nsSVGEffects.cpp:405
(Diff revision 5)
> -    nsSVGPaintingProperty* prop = new nsSVGPaintingProperty(maskUri, aFrame,
> -                                                            false);
> +    bool hasRef = false;
> +    if (maskUri) {
> +      maskUri->GetHasRef(&hasRef);
> +    }
> +
> +    // Accrording to maskUri, nsSVGPaintingProperty's ctor may tigger an

trigger (rather than tigger).
Pushed by cku@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0e7ce13991ca
Download an SVG resource only if the mask URL consists of a fragment. r=heycam
https://hg.mozilla.org/mozilla-central/rev/0e7ce13991ca
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.