Closed
Bug 1383792
Opened 8 years ago
Closed 8 years ago
The "Manage Account" string on Firefox Account should be "Manage account"
Categories
(Firefox :: Settings UI, defect, P1)
Tracking
()
VERIFIED
FIXED
Firefox 56
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | verified |
People
(Reporter: miriapodzemos.my, Assigned: evanxd)
References
Details
(Whiteboard: [photon-preference])
Attachments
(3 files)
Firefox Account.png
[Affected versions]:
Nightly 56.0a1, Build ID 20170723100358
[Affected platforms]:
Platforms: Windows 10 x 64 and Mac OS X 10.12
[Steps to reproduce]:
1. Launch Nightly
2. Go to "about:preferences"
3. Check the Firefox Account tab
[Expected result]:
Firefox Account section is changed and reorganised (attached screenshot) per preferences reorg. document
[Actual result]:
Firefox Account section is displayed as before - with no changes implemented in the latest build.
|
Assignee | |
Comment 1•8 years ago
|
||
Hi Deac,
You need to login into Firefox Account to check the change.
But the string change (Manage Account) is not correct I will update that here.
Thank you.
Flags: needinfo?(alin.deac)
|
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → evan
Status: NEW → ASSIGNED
Flags: qe-verify+
Priority: -- → P1
QA Contact: hani.yacoub
|
|
Assignee | |
Updated•8 years ago
|
Summary: Firefox Account - no changes are visible in the latest build → The "Manage Account" string on Firefox Account should be "Manage account"
|
|
Assignee | |
Comment 2•8 years ago
|
||
In original spec, there is no this string change. But let's fix it here.
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8889716 -
Flags: review?(jaws)
|
|
Assignee | |
Comment 4•8 years ago
|
||
Hi Jared,
Could you help review the patch? This is a string change patch.
Thank you.
|
||
Updated•8 years ago
|
Target Milestone: --- → Firefox 56
|
||
Comment 5•8 years ago
|
||
Hi Michelle, can you confirm that we should be changing from "Manage account" to "Manage Account"?
Flags: needinfo?(mheubusch)
|
|
||
Comment 6•8 years ago
|
||
Sorry, I meant from "Manage Account" to "Manage account".
Yes, "Manage account" is correct in this context.
Flags: needinfo?(mheubusch)
|
|
||
Comment 8•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8889716 [details]
Bug 1383792 - Change the "Manage Account" to "Manage account".
https://reviewboard.mozilla.org/r/160780/#review166480
Attachment #8889716 -
Flags: review?(jaws) → review+
|
|
Assignee | |
Comment 9•8 years ago
|
||
Thank you for reviewing, Jared. Let's land it.
Keywords: checkin-needed
|
||
Comment 10•8 years ago
|
||
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/989b6198392e
Change the "Manage Account" to "Manage account". r=jaws
Keywords: checkin-needed
|
|
||
Comment 11•8 years ago
|
||
| bugherder | ||
|
Reporter | |
Comment 12•8 years ago
|
||
Thank you for clarification. Comment 1 acknowledged and after login, it looks good. Also the change "Manage Account" to "Manage account" will be verified after landing.
Flags: needinfo?(alin.deac)
|
||
Comment 13•8 years ago
|
||
Verified as fixed on latest Nightly 56.0a1, build ID 20170726155629 on Window 10, Ubuntu 16.04 and Mac OS X 10.12.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•