Closed Bug 1383792 Opened 7 years ago Closed 7 years ago

The "Manage Account" string on Firefox Account should be "Manage account"

Categories

(Firefox :: Settings UI, defect, P1)

56 Branch
Unspecified
All
defect

Tracking

()

VERIFIED FIXED
Firefox 56
Tracking Status
firefox56 --- verified

People

(Reporter: miriapodzemos.my, Assigned: evanxd)

References

Details

(Whiteboard: [photon-preference])

Attachments

(3 files)

Attached image Firefox Account.png
[Affected versions]: 
Nightly 56.0a1, Build ID 20170723100358

[Affected platforms]:
Platforms: Windows 10 x 64 and Mac OS X 10.12

[Steps to reproduce]:
1. Launch Nightly
2. Go to "about:preferences"
3. Check the Firefox Account tab

[Expected result]:
Firefox Account section is changed and reorganised (attached screenshot) per preferences reorg. document

[Actual result]:
Firefox Account section is displayed as before - with no changes implemented in the latest build.
Blocks: 1365133
Whiteboard: [photon-preference]
Hi Deac,

You need to login into Firefox Account to check the change.

But the string change (Manage Account) is not correct I will update that here.

Thank you.
Flags: needinfo?(alin.deac)
Assignee: nobody → evan
Status: NEW → ASSIGNED
Flags: qe-verify+
Priority: -- → P1
QA Contact: hani.yacoub
Summary: Firefox Account - no changes are visible in the latest build → The "Manage Account" string on Firefox Account should be "Manage account"
In original spec, there is no this string change. But let's fix it here.
Attachment #8889716 - Flags: review?(jaws)
Hi Jared,

Could you help review the patch? This is a string change patch.

Thank you.
Target Milestone: --- → Firefox 56
Hi Michelle, can you confirm that we should be changing from "Manage account" to "Manage Account"?
Flags: needinfo?(mheubusch)
Sorry, I meant from "Manage Account" to "Manage account".
Yes, "Manage account" is correct in this context.
Flags: needinfo?(mheubusch)
Comment on attachment 8889716 [details]
Bug 1383792 - Change the "Manage Account" to "Manage account".

https://reviewboard.mozilla.org/r/160780/#review166480
Attachment #8889716 - Flags: review?(jaws) → review+
Thank you for reviewing, Jared. Let's land it.
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/989b6198392e
Change the "Manage Account" to "Manage account". r=jaws
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/989b6198392e
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Thank you for clarification. Comment 1 acknowledged and after login, it looks good. Also the change  "Manage Account" to "Manage account" will be verified after landing.
Flags: needinfo?(alin.deac)
Verified as fixed on latest Nightly 56.0a1, build ID 20170726155629 on Window 10, Ubuntu 16.04 and Mac OS X 10.12.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.